[GitHub] oschaaf commented on issue #1776: Redis: Use Redis DB-Index when computing the SystemCache lookup key

2018-06-28 Thread GitBox
oschaaf commented on issue #1776: Redis: Use Redis DB-Index when computing the SystemCache lookup key URL: https://github.com/apache/incubator-pagespeed-mod/pull/1776#issuecomment-401184350 Merging this as-is in to solve this issue, I will file a separate issue on the REDIS_PORT being set

[GitHub] oschaaf commented on issue #1776: Redis: Use Redis DB-Index when computing the SystemCache lookup key

2018-06-08 Thread GitBox
oschaaf commented on issue #1776: Redis: Use Redis DB-Index when computing the SystemCache lookup key URL: https://github.com/apache/incubator-pagespeed-mod/pull/1776#issuecomment-395704856 Disabled the test. I need to dive in to the specifics of `REDIS_PORT` usage, but that's out of scop

[GitHub] oschaaf commented on issue #1776: Redis: Use Redis DB-Index when computing the SystemCache lookup key

2018-06-08 Thread GitBox
oschaaf commented on issue #1776: Redis: Use Redis DB-Index when computing the SystemCache lookup key URL: https://github.com/apache/incubator-pagespeed-mod/pull/1776#issuecomment-395697391 checkin tests not passing. It seems that REDIS_PORT is set as an environment variable, when we're n

[GitHub] oschaaf commented on issue #1776: Redis: Use Redis DB-Index when computing the SystemCache lookup key

2018-06-07 Thread GitBox
oschaaf commented on issue #1776: Redis: Use Redis DB-Index when computing the SystemCache lookup key URL: https://github.com/apache/incubator-pagespeed-mod/pull/1776#issuecomment-395513209 (rebased this PR so we can hopefully observe how CI feels about this change ) -

[GitHub] oschaaf commented on issue #1776: Redis: Use Redis DB-Index when computing the SystemCache lookup key

2018-06-07 Thread GitBox
oschaaf commented on issue #1776: Redis: Use Redis DB-Index when computing the SystemCache lookup key URL: https://github.com/apache/incubator-pagespeed-mod/pull/1776#issuecomment-395478749 (off course, CI is till broken, working on figuring out how to fix that) --