[jira] [Updated] (PARQUET-1533) TestSnappy() throws OOM exception with Parquet-1485 change

2019-02-18 Thread Xinli Shang (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xinli Shang updated PARQUET-1533: - Description: Parquet-1485 initialize the buffer size(inputBuffer and outputBuffer) from 0 to 1

[jira] [Updated] (PARQUET-1533) TestSnappy() throws OOM exception with Parquet-1485 change

2019-02-18 Thread Xinli Shang (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xinli Shang updated PARQUET-1533: - Description: Parquet-1485 initialize the buffer size(inputBuffer and outputBuffer) from 0 to 1

[jira] [Updated] (PARQUET-1533) TestSnappy() throws OOM exception with Parquet-1485 change

2019-02-18 Thread Xinli Shang (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xinli Shang updated PARQUET-1533: - Description: Parquet-1485 initialize the buffer size(inputBuffer and outputBuffer) from 0 to 1

[jira] [Created] (PARQUET-1533) TestSnappy() throws OOM exception with Parquet-1485 change

2019-02-18 Thread Xinli Shang (JIRA)
Xinli Shang created PARQUET-1533: Summary: TestSnappy() throws OOM exception with Parquet-1485 change Key: PARQUET-1533 URL: https://issues.apache.org/jira/browse/PARQUET-1533 Project: Parquet

Re: [DISCUSS] Upgrade to Jackson 2.x and remove the shading

2019-02-18 Thread Ryan Blue
Qinghui, Parquet source uses the unshaded dependencies, but those dependencies are rewritten in every module's build. That way source code remains compatible with Jackson and shading is just part of the build. I've closed PARQUET-1281 with "Not a problem". rb On Mon, Feb 18, 2019 at 9:04 AM XU Q

[jira] [Resolved] (PARQUET-1281) Jackson dependency

2019-02-18 Thread Ryan Blue (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-1281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Blue resolved PARQUET-1281. Resolution: Not A Problem > Jackson dependency > -- > > Key: PARQ

Re: [DISCUSS] Upgrade to Jackson 2.x and remove the shading

2019-02-18 Thread XU Qinghui
I think it's necessary to shade jackson, as it is used a lot in different environment (with different versions). But it turns out that the parquet-jackson is not used everywhere inside parquet-mr (PARQUET-1281 ). I brought up this subject some whi

Re: [DISCUSS] Upgrade to Jackson 2.x and remove the shading

2019-02-18 Thread Ryan Blue
I don't think that removing the shading is a good idea. Jackson is a very common dependency and pulling in projects that use different versions has caused a lot of headache. Why go backward and make Parquet vulnerable to those problems? I don't see a good justification for it. On Mon, Feb 18, 2019

Re: [DISCUSS] Upgrade to Jackson 2.x and remove the shading

2019-02-18 Thread Jacques Nadeau
I haven't looked at the usage but would wonder if the core modules truly need jackson. I don't think most of the systems that read Parquet use the jackson part (?). If so, maybe the code could be refactored to remove the dependency and it be moved to an optional component. We want to do the same th

[DISCUSS] Upgrade to Jackson 2.x and remove the shading

2019-02-18 Thread Driesprong, Fokko
Hi all, Recently I've opened a PR to move from Jackson 1.x to Jackson 2.9 . I've also removed the shading project since most libraries are up to date with Jackson 2.x. Gabor suggested having a discussion on the mailing list to discuss the removal of t