[jira] [Commented] (PARQUET-2167) CLI show footer command fails if Parquet file contains date fields

[ https://issues.apache.org/jira/browse/PARQUET-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570553#comment-17570553 ] ASF GitHub Bot commented on PARQUET-2167: - shangxinli commented on PR #980: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #980: PARQUET-2167: Fix CLI serializing footer with date fields

shangxinli commented on PR #980: URL: https://github.com/apache/parquet-mr/pull/980#issuecomment-1193400394 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [parquet-mr] shangxinli commented on pull request #971: PARQUET-2134: Improve binding to ByteBufferReadable

shangxinli commented on PR #971: URL: https://github.com/apache/parquet-mr/pull/971#issuecomment-1193400138 This PR is combined with https://github.com/apache/parquet-mr/pull/951. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (PARQUET-2134) Incorrect type checking in HadoopStreams.wrap

[ https://issues.apache.org/jira/browse/PARQUET-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570552#comment-17570552 ] ASF GitHub Bot commented on PARQUET-2134: - shangxinli commented on PR #971: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on PR #960: URL: https://github.com/apache/parquet-mr/pull/960#issuecomment-1193399760 @sunchao Can you have a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r928315330 ## parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java: ## @@ -379,4 +427,120 @@ public void remove() { second.remove(); }

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r928315196 ## parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java: ## @@ -238,8 +257,31 @@ public int read(byte[] bytes, int off, int len) { }

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r928314985 ## parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java: ## @@ -238,8 +257,31 @@ public int read(byte[] bytes, int off, int len) { }

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r928313950 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -157,4 +165,80 @@ public void reset() throws IOException { public

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r928314142 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -157,4 +165,80 @@ public void reset() throws IOException { public

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r928313950 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -157,4 +165,80 @@ public void reset() throws IOException { public

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r928313950 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -157,4 +165,80 @@ public void reset() throws IOException { public

[jira] [Commented] (PARQUET-2069) Parquet file containing arrays, written by Parquet-MR, cannot be read again by Parquet-MR

[ https://issues.apache.org/jira/browse/PARQUET-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570547#comment-17570547 ] ASF GitHub Bot commented on PARQUET-2069: - shangxinli commented on code in PR #957: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #957: PARQUET-2069: Allow list and array record types to be compatible.

shangxinli commented on code in PR #957: URL: https://github.com/apache/parquet-mr/pull/957#discussion_r928310312 ## parquet-avro/src/main/java/org/apache/parquet/avro/AvroReadSupport.java: ## @@ -136,10 +137,22 @@ public RecordMaterializer prepareForRead( GenericData

[jira] [Commented] (PARQUET-2126) Thread safety bug in CodecFactory

[ https://issues.apache.org/jira/browse/PARQUET-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570545#comment-17570545 ] ASF GitHub Bot commented on PARQUET-2126: - shangxinli commented on PR #959: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #959: PARQUET-2126: Make cached (de)compressors thread-safe

shangxinli commented on PR #959: URL: https://github.com/apache/parquet-mr/pull/959#issuecomment-1193390004 @theosib-amazon, I am not concerned if release/close isn't called and I agree the caller must call release/close after finishing. My question is that before release/close is called,

[jira] [Commented] (PARQUET-2042) Unwrap common Protobuf wrappers and logical Timestamps, Date, TimeOfDay

[ https://issues.apache.org/jira/browse/PARQUET-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570544#comment-17570544 ] ASF GitHub Bot commented on PARQUET-2042: - shangxinli commented on PR #900: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #900: PARQUET-2042: Add support for unwrapping common Protobuf wrappers and…

shangxinli commented on PR #900: URL: https://github.com/apache/parquet-mr/pull/900#issuecomment-1193386419 I think we are close to merge this PR. Resolve the conflict and use the imports , then we can merge. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (PARQUET-2042) Unwrap common Protobuf wrappers and logical Timestamps, Date, TimeOfDay

[ https://issues.apache.org/jira/browse/PARQUET-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570543#comment-17570543 ] ASF GitHub Bot commented on PARQUET-2042: - shangxinli commented on code in PR #900: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #900: PARQUET-2042: Add support for unwrapping common Protobuf wrappers and…

shangxinli commented on code in PR #900: URL: https://github.com/apache/parquet-mr/pull/900#discussion_r928306582 ## parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoMessageConverter.java: ## @@ -427,6 +485,218 @@ public void addBinary(Binary binary) { } +

[jira] [Commented] (PARQUET-2042) Unwrap common Protobuf wrappers and logical Timestamps, Date, TimeOfDay

[ https://issues.apache.org/jira/browse/PARQUET-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570542#comment-17570542 ] ASF GitHub Bot commented on PARQUET-2042: - shangxinli commented on code in PR #900: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #900: PARQUET-2042: Add support for unwrapping common Protobuf wrappers and…

shangxinli commented on code in PR #900: URL: https://github.com/apache/parquet-mr/pull/900#discussion_r928306114 ## parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoSchemaConverter.java: ## @@ -97,6 +127,46 @@ public MessageType convert(Class protobufClass) {

[GitHub] [parquet-mr] shangxinli merged pull request #956: Bump hadoop-common from 2.10.1 to 3.2.3

shangxinli merged PR #956: URL: https://github.com/apache/parquet-mr/pull/956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (PARQUET-2134) Incorrect type checking in HadoopStreams.wrap

[ https://issues.apache.org/jira/browse/PARQUET-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570538#comment-17570538 ] ASF GitHub Bot commented on PARQUET-2134: - shangxinli commented on PR #951: URL:

[jira] [Commented] (PARQUET-2134) Incorrect type checking in HadoopStreams.wrap

[ https://issues.apache.org/jira/browse/PARQUET-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570539#comment-17570539 ] ASF GitHub Bot commented on PARQUET-2134: - shangxinli merged PR #951: URL:

[GitHub] [parquet-mr] shangxinli merged pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap

shangxinli merged PR #951: URL: https://github.com/apache/parquet-mr/pull/951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [parquet-mr] shangxinli commented on pull request #951: PARQUET-2134: Fix type checking in HadoopStreams.wrap

shangxinli commented on PR #951: URL: https://github.com/apache/parquet-mr/pull/951#issuecomment-1193383006 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To