[jira] [Commented] (PARQUET-1222) Specify a well-defined sorting order for float and double types

2022-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643692#comment-17643692 ] ASF GitHub Bot commented on PARQUET-1222: - emkornfield commented on PR #185: URL:

[GitHub] [parquet-format] emkornfield commented on pull request #185: PARQUET-1222: [Format] Add deails about sort order to README.md

2022-12-05 Thread GitBox
emkornfield commented on PR #185: URL: https://github.com/apache/parquet-format/pull/185#issuecomment-1338880938 @gszadovszky thanks for the feedback I tried to address it in the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (PARQUET-2212) Add ByteBuffer api for decryptors to allow direct memory to be decrypted

2022-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643508#comment-17643508 ] ASF GitHub Bot commented on PARQUET-2212: - parthchandra commented on code in PR #1008: URL:

[GitHub] [parquet-mr] parthchandra commented on a diff in pull request #1008: PARQUET-2212: Add ByteBuffer api for decryptors to allow direct memory to be decrypted

2022-12-05 Thread GitBox
parthchandra commented on code in PR #1008: URL: https://github.com/apache/parquet-mr/pull/1008#discussion_r1039958501 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java: ## @@ -133,11 +135,36 @@ public DataPage readPage() { public

[jira] [Commented] (PARQUET-2149) Implement async IO for Parquet file reader

2022-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643502#comment-17643502 ] ASF GitHub Bot commented on PARQUET-2149: - parthchandra commented on code in PR #968: URL:

[GitHub] [parquet-mr] parthchandra commented on a diff in pull request #968: PARQUET-2149: Async IO implementation for ParquetFileReader

2022-12-05 Thread GitBox
parthchandra commented on code in PR #968: URL: https://github.com/apache/parquet-mr/pull/968#discussion_r1039934636 ## parquet-common/src/main/java/org/apache/parquet/bytes/AsyncMultiBufferInputStream.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (PARQUET-2184) Improve SnappyCompressor buffer expansion performance

2022-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643376#comment-17643376 ] ASF GitHub Bot commented on PARQUET-2184: - abaranec commented on PR #993: URL:

[GitHub] [parquet-mr] abaranec commented on pull request #993: PARQUET-2184: Improve the allocation behavior of SnappyCompressor

2022-12-05 Thread GitBox
abaranec commented on PR #993: URL: https://github.com/apache/parquet-mr/pull/993#issuecomment-1337501132 @shangxinli Sorry it took so long to do this. I resolved the conflicts. The changes all essentially moved into NonBlockedCompressor, I also incorporated the two changes you