[jira] [Commented] (PARQUET-2075) Unified Rewriter Tool

2022-12-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651841#comment-17651841 ] ASF GitHub Bot commented on PARQUET-2075: - shangxinli commented on code in PR #1014: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #1014: PARQUET-2075: Implement unified file rewriter

2022-12-24 Thread GitBox
shangxinli commented on code in PR #1014: URL: https://github.com/apache/parquet-mr/pull/1014#discussion_r1056882191 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/ParquetRewriter.java: ## @@ -0,0 +1,733 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (PARQUET-2075) Unified Rewriter Tool

2022-12-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651840#comment-17651840 ] ASF GitHub Bot commented on PARQUET-2075: - shangxinli commented on code in PR #1014: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #1014: PARQUET-2075: Implement unified file rewriter

2022-12-24 Thread GitBox
shangxinli commented on code in PR #1014: URL: https://github.com/apache/parquet-mr/pull/1014#discussion_r1056881216 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/ParquetRewriter.java: ## @@ -0,0 +1,733 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (PARQUET-2075) Unified Rewriter Tool

2022-12-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651839#comment-17651839 ] ASF GitHub Bot commented on PARQUET-2075: - shangxinli commented on PR #1014: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #1014: PARQUET-2075: Implement unified file rewriter

2022-12-24 Thread GitBox
shangxinli commented on PR #1014: URL: https://github.com/apache/parquet-mr/pull/1014#issuecomment-1364593726 If you can add more unit tests, particularly the combinations of prune, mask, trans-compression etc. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (PARQUET-2075) Unified Rewriter Tool

2022-12-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651838#comment-17651838 ] ASF GitHub Bot commented on PARQUET-2075: - shangxinli commented on PR #1014: URL:

[GitHub] [parquet-mr] shangxinli commented on pull request #1014: PARQUET-2075: Implement unified file rewriter

2022-12-24 Thread GitBox
shangxinli commented on PR #1014: URL: https://github.com/apache/parquet-mr/pull/1014#issuecomment-1364592919 I just left some comments initially. I will spend more time on it. @ggershinsky If you have time, can you have a look too? -- This is an automated message from the Apache

[jira] [Commented] (PARQUET-2075) Unified Rewriter Tool

2022-12-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651837#comment-17651837 ] ASF GitHub Bot commented on PARQUET-2075: - shangxinli commented on code in PR #1014: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #1014: PARQUET-2075: Implement unified file rewriter

2022-12-24 Thread GitBox
shangxinli commented on code in PR #1014: URL: https://github.com/apache/parquet-mr/pull/1014#discussion_r1056879931 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/ParquetRewriter.java: ## @@ -0,0 +1,733 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (PARQUET-2075) Unified Rewriter Tool

2022-12-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651836#comment-17651836 ] ASF GitHub Bot commented on PARQUET-2075: - shangxinli commented on code in PR #1014: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #1014: PARQUET-2075: Implement unified file rewriter

2022-12-24 Thread GitBox
shangxinli commented on code in PR #1014: URL: https://github.com/apache/parquet-mr/pull/1014#discussion_r1056879313 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/ParquetRewriter.java: ## @@ -0,0 +1,733 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (PARQUET-2075) Unified Rewriter Tool

2022-12-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651835#comment-17651835 ] ASF GitHub Bot commented on PARQUET-2075: - shangxinli commented on code in PR #1014: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #1014: PARQUET-2075: Implement unified file rewriter

2022-12-24 Thread GitBox
shangxinli commented on code in PR #1014: URL: https://github.com/apache/parquet-mr/pull/1014#discussion_r1056879143 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/ParquetRewriter.java: ## @@ -0,0 +1,733 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (PARQUET-2075) Unified Rewriter Tool

2022-12-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651834#comment-17651834 ] ASF GitHub Bot commented on PARQUET-2075: - shangxinli commented on code in PR #1014: URL:

[jira] [Commented] (PARQUET-2075) Unified Rewriter Tool

2022-12-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651833#comment-17651833 ] ASF GitHub Bot commented on PARQUET-2075: - shangxinli commented on code in PR #1014: URL:

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #1014: PARQUET-2075: Implement unified file rewriter

2022-12-24 Thread GitBox
shangxinli commented on code in PR #1014: URL: https://github.com/apache/parquet-mr/pull/1014#discussion_r1056877518 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/RewriteOptions.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #1014: PARQUET-2075: Implement unified file rewriter

2022-12-24 Thread GitBox
shangxinli commented on code in PR #1014: URL: https://github.com/apache/parquet-mr/pull/1014#discussion_r1056877460 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/rewrite/RewriteOptions.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation