[jira] [Commented] (PARQUET-2159) Parquet bit-packing de/encode optimization

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682895#comment-17682895 ] ASF GitHub Bot commented on PARQUET-2159: - wgtmac commented on PR #1011: URL: h

[GitHub] [parquet-mr] wgtmac commented on pull request #1011: PARQUET-2159: java17 vector parquet bit-packing decode optimization

2023-01-31 Thread via GitHub
wgtmac commented on PR #1011: URL: https://github.com/apache/parquet-mr/pull/1011#issuecomment-1411584288 > > > Sorry for the delay. I have left some comments and the implementation is overall looking good. Thanks @jiangjiguang for your effort! > > > My main concern is the extensibility t

[jira] [Commented] (PARQUET-2159) Parquet bit-packing de/encode optimization

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682892#comment-17682892 ] ASF GitHub Bot commented on PARQUET-2159: - wgtmac commented on code in PR #1011

[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #1011: PARQUET-2159: java17 vector parquet bit-packing decode optimization

2023-01-31 Thread via GitHub
wgtmac commented on code in PR #1011: URL: https://github.com/apache/parquet-mr/pull/1011#discussion_r1092845969 ## parquet-generator/src/main/resources/ByteBitPacking512VectorLE: ## @@ -0,0 +1,3095 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mor

[jira] [Commented] (PARQUET-2149) Implement async IO for Parquet file reader

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682807#comment-17682807 ] ASF GitHub Bot commented on PARQUET-2149: - wgtmac commented on PR #968: URL: ht

[GitHub] [parquet-mr] wgtmac commented on pull request #968: PARQUET-2149: Async IO implementation for ParquetFileReader

2023-01-31 Thread via GitHub
wgtmac commented on PR #968: URL: https://github.com/apache/parquet-mr/pull/968#issuecomment-1411338630 > @kazuyukitanimura @steveloughran @kbendick @ggershinsky @wgtmac @theosib-amazon Do you still have comments? It looks good to me. Please feel free to merge as you see fit. @shangxi

[jira] [Commented] (PARQUET-2173) Fix parquet build against hadoop 3.3.3+

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682805#comment-17682805 ] ASF GitHub Bot commented on PARQUET-2173: - wgtmac commented on PR #985: URL: ht

[GitHub] [parquet-mr] wgtmac commented on pull request #985: PARQUET-2173. Fix parquet build against hadoop 3.3.3+

2023-01-31 Thread via GitHub
wgtmac commented on PR #985: URL: https://github.com/apache/parquet-mr/pull/985#issuecomment-1411336266 It looks good to me but I don't have the privilege to merge. May I request your help? @ggershinsky @shangxinli @gszadovszky -- This is an automated message from the Apache Git S

[jira] [Commented] (PARQUET-758) [Format] HALF precision FLOAT Logical type

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682674#comment-17682674 ] ASF GitHub Bot commented on PARQUET-758: pitrou commented on code in PR #184: UR

[GitHub] [parquet-format] pitrou commented on a diff in pull request #184: PARQUET-758: Add Float16/Half-float logical type

2023-01-31 Thread via GitHub
pitrou commented on code in PR #184: URL: https://github.com/apache/parquet-format/pull/184#discussion_r1092267094 ## src/main/thrift/parquet.thrift: ## @@ -232,6 +232,7 @@ struct MapType {} // see LogicalTypes.md struct ListType {}// see LogicalTypes.md struct EnumTyp

[jira] [Commented] (PARQUET-2173) Fix parquet build against hadoop 3.3.3+

2023-01-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682474#comment-17682474 ] ASF GitHub Bot commented on PARQUET-2173: - steveloughran commented on PR #985:

[GitHub] [parquet-mr] steveloughran commented on pull request #985: PARQUET-2173. Fix parquet build against hadoop 3.3.3+

2023-01-31 Thread via GitHub
steveloughran commented on PR #985: URL: https://github.com/apache/parquet-mr/pull/985#issuecomment-1410083313 any plans to merge now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific