[jira] [Commented] (PARQUET-1822) Parquet without Hadoop dependencies

2023-06-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731774#comment-17731774 ] ASF GitHub Bot commented on PARQUET-1822: - amousavigourabi opened a new pull re

[GitHub] [parquet-mr] amousavigourabi opened a new pull request, #1111: PARQUET-1822: Avoid requiring Hadoop installation for reading/writing

2023-06-12 Thread via GitHub
amousavigourabi opened a new pull request, #: URL: https://github.com/apache/parquet-mr/pull/ Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references

[jira] [Commented] (PARQUET-2249) Parquet spec (parquet.thrift) is inconsistent w.r.t. ColumnIndex + NaNs

2023-06-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731626#comment-17731626 ] ASF GitHub Bot commented on PARQUET-2249: - mapleFU commented on code in PR #196

[GitHub] [parquet-format] mapleFU commented on a diff in pull request #196: PARQUET-2249: Add nan_count to handle NaNs in statistics

2023-06-12 Thread via GitHub
mapleFU commented on code in PR #196: URL: https://github.com/apache/parquet-format/pull/196#discussion_r1226712152 ## src/main/thrift/parquet.thrift: ## @@ -886,16 +891,25 @@ union ColumnOrder { * FIXED_LEN_BYTE_ARRAY - unsigned byte-wise comparison * * (*) Becaus

[jira] [Commented] (PARQUET-758) [Format] HALF precision FLOAT Logical type

2023-06-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731621#comment-17731621 ] ASF GitHub Bot commented on PARQUET-758: JFinis commented on PR #184: URL: https

[GitHub] [parquet-format] JFinis commented on pull request #184: PARQUET-758: Add Float16/Half-float logical type

2023-06-12 Thread via GitHub
JFinis commented on PR #184: URL: https://github.com/apache/parquet-format/pull/184#issuecomment-1587367949 > > It isn't clear to me if this should be a logical type or a physical type. We would need understand if there is different handling for forward compatibility purposes (what do we wa

[jira] [Commented] (PARQUET-2249) Parquet spec (parquet.thrift) is inconsistent w.r.t. ColumnIndex + NaNs

2023-06-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731560#comment-17731560 ] ASF GitHub Bot commented on PARQUET-2249: - JFinis commented on PR #196: URL: ht

[GitHub] [parquet-format] JFinis commented on pull request #196: PARQUET-2249: Add nan_count to handle NaNs in statistics

2023-06-12 Thread via GitHub
JFinis commented on PR #196: URL: https://github.com/apache/parquet-format/pull/196#issuecomment-1587083232 I finally have time to continue on this. Sorry for the long wait. As @gszadovszky has highlighted, we have to store a valid double/float value into the min/max bounds of the col

[jira] [Commented] (PARQUET-2249) Parquet spec (parquet.thrift) is inconsistent w.r.t. ColumnIndex + NaNs

2023-06-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731558#comment-17731558 ] ASF GitHub Bot commented on PARQUET-2249: - JFinis commented on code in PR #196:

[GitHub] [parquet-format] JFinis commented on a diff in pull request #196: PARQUET-2249: Add nan_count to handle NaNs in statistics

2023-06-12 Thread via GitHub
JFinis commented on code in PR #196: URL: https://github.com/apache/parquet-format/pull/196#discussion_r1226466358 ## README.md: ## @@ -163,18 +163,25 @@ following rules: [Thrift definition](src/main/thrift/parquet.thrift) in the `ColumnOrder` union. They are summa