Re: [PR] PARQUET-2261: Implement SizeStatistics [parquet-mr]

2023-10-21 Thread via GitHub
wgtmac commented on code in PR #1177: URL: https://github.com/apache/parquet-mr/pull/1177#discussion_r1367696949 ## parquet-column/src/main/java/org/apache/parquet/column/statistics/SizeStatistics.java: ## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[jira] [Commented] (PARQUET-2261) [Format] Add statistics that reflect decoded size to metadata

2023-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778045#comment-17778045 ] ASF GitHub Bot commented on PARQUET-2261: - wgtmac commented on code in PR #1177

Re: [PR] PARQUET-1647: [Java][Parquet] Implement FLOAT16 logical type [parquet-mr]

2023-10-21 Thread via GitHub
zhangjiashen commented on code in PR #1142: URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1367832331 ## parquet-common/src/main/java/org/apache/parquet/type/Float16.java: ## @@ -0,0 +1,339 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one +

[jira] [Commented] (PARQUET-1647) [Java] support for Arrow's float16

2023-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778273#comment-17778273 ] ASF GitHub Bot commented on PARQUET-1647: - zhangjiashen commented on code in PR

Re: [PR] PARQUET-1647: [Java][Parquet] Implement FLOAT16 logical type [parquet-mr]

2023-10-21 Thread via GitHub
zhangjiashen commented on code in PR #1142: URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1367832542 ## parquet-common/src/main/java/org/apache/parquet/type/Float16.java: ## @@ -0,0 +1,307 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one +

[jira] [Commented] (PARQUET-1647) [Java] support for Arrow's float16

2023-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778274#comment-17778274 ] ASF GitHub Bot commented on PARQUET-1647: - zhangjiashen commented on code in PR

[jira] [Commented] (PARQUET-1647) [Java] support for Arrow's float16

2023-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778275#comment-17778275 ] ASF GitHub Bot commented on PARQUET-1647: - zhangjiashen commented on code in PR

Re: [PR] PARQUET-1647: [Java][Parquet] Implement FLOAT16 logical type [parquet-mr]

2023-10-21 Thread via GitHub
zhangjiashen commented on code in PR #1142: URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1367832612 ## parquet-column/src/test/java/org/apache/parquet/io/api/TestBinary.java: ## @@ -268,4 +268,19 @@ public void testCompare() { assertTrue(b1.compareTo(b3)

Re: [PR] PARQUET-1647: [Java][Parquet] Implement FLOAT16 logical type [parquet-mr]

2023-10-21 Thread via GitHub
zhangjiashen commented on code in PR #1142: URL: https://github.com/apache/parquet-mr/pull/1142#discussion_r1367832738 ## parquet-column/src/main/java/org/apache/parquet/column/statistics/Float16Statistics.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundat

[jira] [Commented] (PARQUET-1647) [Java] support for Arrow's float16

2023-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778276#comment-17778276 ] ASF GitHub Bot commented on PARQUET-1647: - zhangjiashen commented on code in PR