Re: [PR] PARQUET-2383: Bump parquet-format to 2.10.0 [parquet-mr]

2023-11-21 Thread via GitHub
Fokko commented on PR #1200: URL: https://github.com/apache/parquet-mr/pull/1200#issuecomment-1822144579 Nice! Op wo 22 nov 2023 om 05:13 schreef Gang Wu ***@***.***> > Merged #1200 into master. > > — > Reply to this emai

[jira] [Commented] (PARQUET-2383) Bump parquet-format to 2.10.0

2023-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788635#comment-17788635 ] ASF GitHub Bot commented on PARQUET-2383: - Fokko commented on PR #1200: URL: ht

[jira] [Resolved] (PARQUET-2383) Bump parquet-format to 2.10.0

2023-11-21 Thread Gang Wu (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gang Wu resolved PARQUET-2383. -- Fix Version/s: 1.14.0 Resolution: Fixed > Bump parquet-format to 2.10.0 >

Re: [PR] PARQUET-2383: Bump parquet-format to 2.10.0 [parquet-mr]

2023-11-21 Thread via GitHub
wgtmac merged PR #1200: URL: https://github.com/apache/parquet-mr/pull/1200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@parquet.apac

[jira] [Commented] (PARQUET-2383) Bump parquet-format to 2.10.0

2023-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788623#comment-17788623 ] ASF GitHub Bot commented on PARQUET-2383: - wgtmac merged PR #1200: URL: https:/

[jira] [Commented] (PARQUET-2383) Bump parquet-format to 2.10.0

2023-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788622#comment-17788622 ] ASF GitHub Bot commented on PARQUET-2383: - wgtmac commented on PR #1200: URL: h

Re: [PR] PARQUET-2383: Bump parquet-format to 2.10.0 [parquet-mr]

2023-11-21 Thread via GitHub
wgtmac commented on PR #1200: URL: https://github.com/apache/parquet-mr/pull/1200#issuecomment-1822076286 Thanks @shangxinli! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] PARQUET-2383: Bump parquet-format to 2.10.0 [parquet-mr]

2023-11-21 Thread via GitHub
shangxinli commented on PR #1200: URL: https://github.com/apache/parquet-mr/pull/1200#issuecomment-1822069538 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[jira] [Commented] (PARQUET-2383) Bump parquet-format to 2.10.0

2023-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788621#comment-17788621 ] ASF GitHub Bot commented on PARQUET-2383: - shangxinli commented on PR #1200: UR

[jira] [Commented] (PARQUET-2221) [Format] Encoding spec incorrect for dictionary fallback

2023-11-21 Thread Micah Kornfield (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788519#comment-17788519 ] Micah Kornfield commented on PARQUET-2221: -- I agree with [~wgtmac] here.  I th

[jira] [Commented] (PARQUET-2374) Add metrics support for parquet file reader

2023-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788449#comment-17788449 ] ASF GitHub Bot commented on PARQUET-2374: - wgtmac commented on code in PR #1187

Re: [PR] PARQUET-2374: Add metrics support for parquet file reader [parquet-mr]

2023-11-21 Thread via GitHub
wgtmac commented on PR #1187: URL: https://github.com/apache/parquet-mr/pull/1187#issuecomment-1821108258 > For the object stores, things to measure are > > * time to open() and close() a file > * time for a read after a backwards seek > * time for a read after a forwards seek.

[jira] [Commented] (PARQUET-2374) Add metrics support for parquet file reader

2023-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788448#comment-17788448 ] ASF GitHub Bot commented on PARQUET-2374: - wgtmac commented on PR #1187: URL: h

Re: [PR] PARQUET-2374: Add metrics support for parquet file reader [parquet-mr]

2023-11-21 Thread via GitHub
wgtmac commented on code in PR #1187: URL: https://github.com/apache/parquet-mr/pull/1187#discussion_r1400746050 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java: ## @@ -80,10 +80,12 @@ static final class ColumnChunkPageReader implements P

Re: Lossy compression of floating point data

2023-11-21 Thread Michael Bernardi
Hi all, Thank you for your thoughts. In the meantime I've done further experiments and decided against using SZ in its current state. The library has improved, but while experimenting with it I've noticed some issues which don't make it a good fit for inclusion in Parquet. To Gang's questions,

[jira] [Commented] (PARQUET-2378) Problem with a cat

2023-11-21 Thread Gang Wu (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788344#comment-17788344 ] Gang Wu commented on PARQUET-2378: -- Sorry for the late reply. I'm not sure if it is a