Re: [DISCUSS] Alternative design for KMS interaction in parquet-cpp

2020-11-15 Thread Benjamin Kietzman
> would be >>> > preferred that public classes be kept to a minimum. >>> >>> I think some of these classes are non-trivial. If that is the case it >>> would be preferable to put them in an internal namespace to ensure >>> adequate unit testing is in

[DISCUSS] Alternative design for KMS interaction in parquet-cpp

2020-11-11 Thread Benjamin Kietzman
In the context of https://issues.apache.org/jira/browse/ARROW-9318 / https://github.com/apache/arrow/pull/8023 which port the parquet-mr design to c++: there's some question whether that design is consistent with the style and conventions of the c++ implementation of parquet. Here is a Gist with