[GitHub] [parquet-mr] dossett commented on pull request #813: PARQUET-1903: Improve Parquet Protobuf Usability

2021-03-31 Thread GitBox
dossett commented on pull request #813: URL: https://github.com/apache/parquet-mr/pull/813#issuecomment-811145948 I've been in parquet-protobuf code lately and these seem like good changes. @belugabehr I'd be happy to pick this PR up if you like and address some of the minor comments. Th

[GitHub] [parquet-mr] dossett commented on pull request #813: PARQUET-1903: Improve Parquet Protobuf Usability

2020-09-28 Thread GitBox
dossett commented on pull request #813: URL: https://github.com/apache/parquet-mr/pull/813#issuecomment-699986621 That's a good one too @belugabehr ! I posed this question on the parquet dev list about proto3 if you are interested: http://mail-archives.apache.org/mod_mbox/parquet-

[GitHub] [parquet-mr] dossett commented on pull request #813: PARQUET-1903: Improve Parquet Protobuf Usability

2020-09-25 Thread GitBox
dossett commented on pull request #813: URL: https://github.com/apache/parquet-mr/pull/813#issuecomment-698955956 @belugabehr This looks really good! I'm probably going to be working a lot with protobuf + parquet in the future, so I'm happy to see changes like this. I'm not a parquet comm