ggershinsky commented on pull request #808:
URL: https://github.com/apache/parquet-mr/pull/808#issuecomment-713498654
> I have some comments otherwise I am fine with this change.
>
> Meanwhile, the title and maybe the jira description do not fit this
change. I think, they should be r
ggershinsky commented on pull request #808:
URL: https://github.com/apache/parquet-mr/pull/808#issuecomment-672788803
> I don't agree we cannot have a meeting about this topic in terms of
transparency. What we have to do is to document here about what we have
discussed and what are the con
ggershinsky commented on pull request #808:
URL: https://github.com/apache/parquet-mr/pull/808#issuecomment-672750035
@shangxinli Indeed, my understanding of this pull request is accurately
described by "'how to transport the settings from the extended
ParquetWriteSupport to CryptoProperti
ggershinsky commented on pull request #808:
URL: https://github.com/apache/parquet-mr/pull/808#issuecomment-671793784
Yep, a couple of concerns related to encryption.
The stated goal of the crypto factory design is to be "transparent to
analytic frameworks, so they can leverage Parquet
ggershinsky commented on pull request #808:
URL: https://github.com/apache/parquet-mr/pull/808#issuecomment-671228812
@shangxinli thanks again for the additional details, it was interesting to
have a glance at your usecase. It is indeed somewhat different from ours. Your
existing pipelin
ggershinsky commented on pull request #808:
URL: https://github.com/apache/parquet-mr/pull/808#issuecomment-670350298
in the meantime, could you send an example of such extended
ParquetWriteSupport?
If CryptoHoodieAvroWriteSupport is the example, could you fix the link
above, I get a 4
ggershinsky commented on pull request #808:
URL: https://github.com/apache/parquet-mr/pull/808#issuecomment-670157959
Thanks @shangxinli for the detailed response, much appreciated! I want to
allocate ample time to get to the bottom of this subject, and with the weekend
starting here, it m
ggershinsky commented on pull request #808:
URL: https://github.com/apache/parquet-mr/pull/808#issuecomment-669725393
> extend ParquetWriteSupport which converts crypto setting in schema..
@shangxinli your previous pull request (already merged) added a very nice
Encryption Factory in