[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #900: PARQUET-2042: Add support for unwrapping common Protobuf wrappers and…

2022-07-24 Thread GitBox
shangxinli commented on code in PR #900: URL: https://github.com/apache/parquet-mr/pull/900#discussion_r928306582 ## parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoMessageConverter.java: ## @@ -427,6 +485,218 @@ public void addBinary(Binary binary) { } + fi

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #900: PARQUET-2042: Add support for unwrapping common Protobuf wrappers and…

2022-07-24 Thread GitBox
shangxinli commented on code in PR #900: URL: https://github.com/apache/parquet-mr/pull/900#discussion_r928306114 ## parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoSchemaConverter.java: ## @@ -97,6 +127,46 @@ public MessageType convert(Class protobufClass) {

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #900: PARQUET-2042: Add support for unwrapping common Protobuf wrappers and…

2022-07-03 Thread GitBox
shangxinli commented on code in PR #900: URL: https://github.com/apache/parquet-mr/pull/900#discussion_r912586665 ## parquet-protobuf/src/main/java/org/apache/parquet/proto/ProtoSchemaConverter.java: ## @@ -97,6 +127,46 @@ public MessageType convert(Class protobufClass) {