[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r950908609 ## parquet-common/src/main/java/org/apache/parquet/bytes/SingleBufferInputStream.java: ## @@ -88,6 +136,21 @@ public long skip(long n) { return bytesToSkip;

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r950908296 ## parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java: ## @@ -379,4 +427,120 @@ public void remove() { second.remove(); }

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r950908215 ## parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java: ## @@ -238,8 +257,31 @@ public int read(byte[] bytes, int off, int len) { }

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r950908127 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -138,6 +134,18 @@ public int read(byte[] b, int off, int len) throws IOEx

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r950907839 ## parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java: ## @@ -238,8 +257,31 @@ public int read(byte[] bytes, int off, int len) { }

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r950906824 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -138,6 +134,18 @@ public int read(byte[] b, int off, int len) throws IOEx

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r950903406 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -157,4 +165,80 @@ public void reset() throws IOException { public boole

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r950903342 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -157,4 +165,80 @@ public void reset() throws IOException { public boole

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r928315330 ## parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java: ## @@ -379,4 +427,120 @@ public void remove() { second.remove(); }

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r928315196 ## parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java: ## @@ -238,8 +257,31 @@ public int read(byte[] bytes, int off, int len) { }

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r928314985 ## parquet-common/src/main/java/org/apache/parquet/bytes/MultiBufferInputStream.java: ## @@ -238,8 +257,31 @@ public int read(byte[] bytes, int off, int len) { }

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r928313950 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -157,4 +165,80 @@ public void reset() throws IOException { public boole

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r928314142 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -157,4 +165,80 @@ public void reset() throws IOException { public boole

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r928313950 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -157,4 +165,80 @@ public void reset() throws IOException { public boole

[GitHub] [parquet-mr] shangxinli commented on a diff in pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

shangxinli commented on code in PR #960: URL: https://github.com/apache/parquet-mr/pull/960#discussion_r928313950 ## parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java: ## @@ -157,4 +165,80 @@ public void reset() throws IOException { public boole