[GitHub] [parquet-mr] shangxinli commented on pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-12-03 Thread GitBox
shangxinli commented on PR #960: URL: https://github.com/apache/parquet-mr/pull/960#issuecomment-1336239074 @theosib-amazon Thanks again for your contribution! I see the comments are generally around duplicating code, refactoring, and making code maintainable. If you have a measurement of i

[GitHub] [parquet-mr] shangxinli commented on pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-07-24 Thread GitBox
shangxinli commented on PR #960: URL: https://github.com/apache/parquet-mr/pull/960#issuecomment-1193399760 @sunchao Can you have a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [parquet-mr] shangxinli commented on pull request #960: Performance optimization: Move all LittleEndianDataInputStream functionality into ByteBufferInputStream

2022-05-15 Thread GitBox
shangxinli commented on PR #960: URL: https://github.com/apache/parquet-mr/pull/960#issuecomment-1127097695 Is the '5% to 15%' gain from this change or along with other changes? If it is later, can you share the point to other changes? Like to see the overall changes before committing.