Re: [VOTE] Release Apache Parquet 1.12.0 RC1

2021-01-29 Thread Aaron Niskode-Dossett
I haven't seen this java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer; problem before, but some research suggest that this can happen with JDK > 8 is used to compile code that gets run with JDK 8. Setting --source and --target alone do not address the problem, but ad

Re: [VOTE] Release Apache Parquet 1.12.0 RC1

2021-01-29 Thread Wang, Yuming
It seems there is something wrong with JDK 8: java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer; at org.apache.parquet.bytes.CapacityByteArrayOutputStream.write(CapacityByteArrayOutputStream.java:197) at org.apache.parquet.column.values.rle.RunLen

Re: [VOTE] Release Apache Parquet 1.12.0 RC1

2021-01-29 Thread Gidon Gershinsky
Regarding the technical reason behind this addition - we needed it to enable encryption in one of the writing paths. Cheers, Gidon On Thu, Jan 28, 2021 at 7:09 PM Aaron Niskode-Dossett wrote: > My (non-binding) is that this is ok. In a different Apache project, we > didn't allow a change like

Re: [VOTE] Release Apache Parquet 1.12.0 RC1

2021-01-28 Thread Aaron Niskode-Dossett
My (non-binding) is that this is ok. In a different Apache project, we didn't allow a change like that in minor versions and it delayed some key work by several months. On Thu, Jan 28, 2021 at 3:00 AM Gabor Szadovszky wrote: > Thanks a lot, Fokko. > > Regarding the breaking change. We have the

Re: [VOTE] Release Apache Parquet 1.12.0 RC1

2021-01-28 Thread Gabor Szadovszky
Thanks a lot, Fokko. Regarding the breaking change. We have the maven plugin japicmp executed in the verify phase so I was curious why it did not catch this issue. It seems the plugin allows source incompatible changes for minor version upgrades by default. It sounds reasonable to me but I am curi

Re: [VOTE] Release Apache Parquet 1.12.0 RC1

2021-01-27 Thread Driesprong, Fokko
Thanks for running the release Gabor! The signature checks out: MacBook-Pro-van-Fokko:Downloads fokkodriesprong$ curl https://downloads.apache.org/parquet/KEYS > KEYS % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload To

[VOTE] Release Apache Parquet 1.12.0 RC1

2021-01-27 Thread Gabor Szadovszky
Hi everyone, I propose the following RC to be released as the official Apache Parquet 1.12.0 release. The commit id is ad59c33e53276572c105b4ccac71293e988adc30 * This corresponds to the tag: apache-parquet-1.12.0-rc1 * https://github.com/apache/parquet-mr/tree/ad59c33e53276572c105b4ccac71293e988a