[
https://issues.apache.org/jira/browse/PARQUET-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425661#comment-16425661
]
ASF GitHub Bot commented on PARQUET-1256:
-----------------------------------------
xhochy commented on issue #450: PARQUET-1256: Add --print-key-value-metadata
option to parquet_reader tool
URL: https://github.com/apache/parquet-cpp/pull/450#issuecomment-378632891
@JacekPliszka The build fails in Travis due to a conversion problem:
```
/home/travis/build/apache/parquet-cpp/src/parquet/printer.cc: In member
function ‘void parquet::ParquetFilePrinter::DebugPrint(std::ostream&,
std::list<int>, bool, bool, const char*)’:
/home/travis/build/apache/parquet-cpp/src/parquet/printer.cc:47:64: error:
conversion to ‘int’ from ‘int64_t {aka long int}’ may alter its value
[-Werror=conversion]
int size_of_key_value_metadata = key_value_metadata->size();
```
Can you adjust the int type to the correct one? Then this should be ready to
merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Please review and merge: added --print-key-value-metadata option to
> parquet_reader tool
> ---------------------------------------------------------------------------------------
>
> Key: PARQUET-1256
> URL: https://issues.apache.org/jira/browse/PARQUET-1256
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-cpp
> Reporter: Jacek Pliszka
> Priority: Trivial
> Labels: patch
> Fix For: cpp-1.5.0
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Added --print-key-value-metadata option to parquet_reader tool
> https://github.com/apache/parquet-cpp/pull/450
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
