[jira] [Commented] (PARQUET-284) Should use ConcurrentHashMap instead of HashMap in ParquetMetadataConverter

2015-06-19 Thread Tony Yan (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594288#comment-14594288 ] Tony Yan commented on PARQUET-284: -- Thanks for the fix. > Should use ConcurrentHashMap

[jira] [Commented] (PARQUET-284) Should use ConcurrentHashMap instead of HashMap in ParquetMetadataConverter

2015-06-19 Thread Tony Yan (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14594287#comment-14594287 ] Tony Yan commented on PARQUET-284: -- Thanks for the fix. > Should use ConcurrentHashMap

[jira] [Commented] (PARQUET-284) Should use ConcurrentHashMap instead of HashMap in ParquetMetadataConverter

2015-06-18 Thread Alex Levenson (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592964#comment-14592964 ] Alex Levenson commented on PARQUET-284: --- welp, I'm wrong: https://gist.github.com/r

[jira] [Commented] (PARQUET-284) Should use ConcurrentHashMap instead of HashMap in ParquetMetadataConverter

2015-06-18 Thread Alex Levenson (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592963#comment-14592963 ] Alex Levenson commented on PARQUET-284: --- [~yanzt], I've sent a PR to clean up this

[jira] [Commented] (PARQUET-284) Should use ConcurrentHashMap instead of HashMap in ParquetMetadataConverter

2015-06-18 Thread Alex Levenson (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592925#comment-14592925 ] Alex Levenson commented on PARQUET-284: --- Update: the cache was actually never being

[jira] [Commented] (PARQUET-284) Should use ConcurrentHashMap instead of HashMap in ParquetMetadataConverter

2015-06-18 Thread Alex Levenson (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592873#comment-14592873 ] Alex Levenson commented on PARQUET-284: --- How important is it to cache this state? S

[jira] [Commented] (PARQUET-284) Should use ConcurrentHashMap instead of HashMap in ParquetMetadataConverter

2015-05-15 Thread Ryan Blue (JIRA)
[ https://issues.apache.org/jira/browse/PARQUET-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545828#comment-14545828 ] Ryan Blue commented on PARQUET-284: --- Looks like we should probably change that HashMap