[ 
https://issues.apache.org/jira/browse/PARQUET-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172507#comment-15172507
 ] 

Wes McKinney commented on PARQUET-463:
--------------------------------------

see patch https://github.com/apache/parquet-cpp/pull/67

> Add DCHECK* macros for assertions in debug builds
> -------------------------------------------------
>
>                 Key: PARQUET-463
>                 URL: https://issues.apache.org/jira/browse/PARQUET-463
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-cpp
>            Reporter: Wes McKinney
>            Priority: Minor
>
> Some of these macros are already defined in {{parquet/util/logging.h}}, but 
> they are no-ops. This will assist in "can't fail" assertions. See 
> https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED-



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to