[jira] [Commented] (PDFBOX-2576) Improve code quality

2014-12-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259344#comment-14259344 ] ASF subversion and git services commented on PDFBOX-2576: - Commit

[jira] [Commented] (PDFBOX-2576) Improve code quality

2014-12-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259346#comment-14259346 ] ASF subversion and git services commented on PDFBOX-2576: - Commit

[jira] [Commented] (PDFBOX-2576) Improve code quality

2014-12-27 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-2576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259349#comment-14259349 ] ASF subversion and git services commented on PDFBOX-2576: - Commit

Matrix Skew

2014-12-27 Thread John Hewson
Hi All, I’ve been looking at the Matrix class and trying to understand if it has some problems. The Matrix class in PDFBox uses the following matrix: | sx hy 0 | | hx sy 0 | | tx ty 1 | In a PDF file this matrix is represented as the 6-element array [a, b, c, d, e, f] where the meaning of the

Re: Matrix Skew

2014-12-27 Thread Tilman Hausherr
The best way to prove or falsify this theory would be to create a PDF that uses the cm operator, but has different values for hy and hx, and then render the image with PDFBox. Or render PDF files and see what happens... I just changed that method, and get several differences in the

Re: Matrix Skew

2014-12-27 Thread Maruan Sahyoun
Hi, I tried the following with skew being [1 tan a tan b 1 0 0] according to the spec. Matrix matrix = new Matrix(); which gives me [1.0,0.0,0.0,1.0,0.0,0.0] then matrix.setValue(0, 1, 0.5f); matrix.setValue(1, 0, 0.7f); which shall set the tan a and tan b values which gave me

Re: Matrix Skew

2014-12-27 Thread John Hewson
Yes, the pure matrix code seems to work fine. As do the examples which Tilman mentioned. I can’t find any issue with the code itself. However, we make use the following Matrix method: public AffineTransform createAffineTransform() { AffineTransform retval = new AffineTransform(