[jira] [Commented] (PDFBOX-1000) Conforming parser

2012-04-06 Thread Adam Nichols (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248387#comment-13248387 ] Adam Nichols commented on PDFBOX-1000: -- I would prefer you put the changes in tje

[jira] [Commented] (PDFBOX-1226) Counting pages of a PDF gives OutOfMemoryError

2012-02-09 Thread Adam Nichols (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205123#comment-13205123 ] Adam Nichols commented on PDFBOX-1226: -- There are a few different options here, the

[jira] [Commented] (PDFBOX-847) FlateFilter.java swallows Exceptions (should rethrow)

2012-01-24 Thread Adam Nichols (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13192178#comment-13192178 ] Adam Nichols commented on PDFBOX-847: - Should we be catching ZipException and

[jira] [Commented] (PDFBOX-1214) Allow subclassing of PDFParser

2012-01-23 Thread Adam Nichols (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-1214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13191720#comment-13191720 ] Adam Nichols commented on PDFBOX-1214: -- Looks fine to me Allow

[jira] [Commented] (PDFBOX-1000) Conforming parser

2012-01-11 Thread Adam Nichols (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13184677#comment-13184677 ] Adam Nichols commented on PDFBOX-1000: -- First and foremost, I like the good

[jira] [Commented] (PDFBOX-1000) Conforming parser

2012-01-06 Thread Adam Nichols (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13181876#comment-13181876 ] Adam Nichols commented on PDFBOX-1000: -- I'm not sure I understand your approach. I

[jira] [Commented] (PDFBOX-1000) Conforming parser

2012-01-01 Thread Adam Nichols (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13178138#comment-13178138 ] Adam Nichols commented on PDFBOX-1000: -- Lexer: I like the idea of keeping the code

[jira] [Commented] (PDFBOX-1000) Conforming parser

2011-11-07 Thread Adam Nichols (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/PDFBOX-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145743#comment-13145743 ] Adam Nichols commented on PDFBOX-1000: -- There were a few reasons why I wanted to