Re: [PR] Fix restart dup bug after recover a duplicating replica server [incubator-pegasus]

2023-11-16 Thread via GitHub
acelyc111 commented on code in PR #1608: URL: https://github.com/apache/incubator-pegasus/pull/1608#discussion_r1357732684 ## src/replica/duplication/duplication_sync_timer.cpp: ## @@ -107,11 +107,23 @@ void duplication_sync_timer::update_duplication_map( { for (replica_p

Re: [PR] Fix(manual_compact):fix replica lose manual compact finished status after replica migrate bug [incubator-pegasus]

2023-11-16 Thread via GitHub
acelyc111 commented on PR #1666: URL: https://github.com/apache/incubator-pegasus/pull/1666#issuecomment-1815704130 I’m confused how can this patch fix this issue, I guess the reason the compaction progress not update is caused by the [serving](https://github.com/apache/incubator-pegasus/b

Re: [I] Bug(manual_compact):replica lose manual compact finished status after replica migrate [incubator-pegasus]

2023-11-16 Thread via GitHub
acelyc111 commented on issue #1665: URL: https://github.com/apache/incubator-pegasus/issues/1665#issuecomment-1815692995 @ninsmiracle Each replica of a partition will do manual compaction independently, when one node shutdown, the other replicas on other nodes may not start or in progress

[PR] feat(pprof): Supports both heap profiling and heap sampling [incubator-pegasus]

2023-11-16 Thread via GitHub
acelyc111 opened a new pull request, #1684: URL: https://github.com/apache/incubator-pegasus/pull/1684 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub