Re: [PR] feat(duplication): allow remote app name to be specified for duplication [incubator-pegasus]

2024-03-26 Thread via GitHub
empiredan commented on code in PR #1960: URL: https://github.com/apache/incubator-pegasus/pull/1960#discussion_r1540429491 ## src/shell/commands/duplication.cpp: ## @@ -80,35 +81,55 @@ bool add_dup(command_executor *e, shell_context *sc, arguments args) return true;

[I] Meta server crashed in prometheus-cpp library [incubator-pegasus]

2024-03-26 Thread via GitHub
acelyc111 opened a new issue, #1965: URL: https://github.com/apache/incubator-pegasus/issues/1965 Meta server crashed if creating a backup policy with a name contains `-` character, the assert information is as below: ``` meta_server: /data/jenkins/workspace/skv/prebuild_binary-multi-

Re: [I] The amount of data increased after backing up and restoring a partition-splitted table [incubator-pegasus]

2024-03-26 Thread via GitHub
acelyc111 commented on issue #1964: URL: https://github.com/apache/incubator-pegasus/issues/1964#issuecomment-2020826917 It's because the `replica.split.validate_partition_hash` environment is lost on table B. -- This is an automated message from the Apache Git Service. To respond to the

[I] The amount of data increased after backing up and restoring a partition-splitted table [incubator-pegasus]

2024-03-26 Thread via GitHub
acelyc111 opened a new issue, #1964: URL: https://github.com/apache/incubator-pegasus/issues/1964 ## Bug Report Please answer these questions before submitting your issue. Thanks! 1. What did you do? - create a table A - write some data to the table A - count the total

Re: [I] Partition split hung [incubator-pegasus]

2024-03-26 Thread via GitHub
acelyc111 commented on issue #1963: URL: https://github.com/apache/incubator-pegasus/issues/1963#issuecomment-2020426871 Piece of the back trace: ``` Thread 273 (Thread 0x7f3df4dbc700 (LWP 25825)): #0 0x7f3e0f2bbb3b in do_futex_wait.constprop.1 () from /lib64/libpthread.so.0

[I] Partition split hung [incubator-pegasus]

2024-03-26 Thread via GitHub
acelyc111 opened a new issue, #1963: URL: https://github.com/apache/incubator-pegasus/issues/1963 ## Bug Report Please answer these questions before submitting your issue. Thanks! 1. What did you do? Create a table with 8 partitions Write some data to the table Start pa

Re: [PR] fix(duplication): fix plog gc crash [incubator-pegasus]

2024-03-26 Thread via GitHub
empiredan commented on code in PR #1597: URL: https://github.com/apache/incubator-pegasus/pull/1597#discussion_r1539095227 ## src/replica/duplication/load_from_private_log.cpp: ## @@ -168,6 +171,8 @@ void load_from_private_log::find_log_file_to_start() void load_from_private_l

Re: [PR] feat(duplication): allow remote app name to be specified for duplication [incubator-pegasus]

2024-03-26 Thread via GitHub
acelyc111 commented on code in PR #1960: URL: https://github.com/apache/incubator-pegasus/pull/1960#discussion_r1539033696 ## idl/duplication.thrift: ## @@ -66,6 +66,9 @@ struct duplication_add_request // - if false, duplication start state=DS_LOG, // server will repl

Re: [PR] fix(duplication): fix plog gc crash [incubator-pegasus]

2024-03-26 Thread via GitHub
empiredan commented on code in PR #1597: URL: https://github.com/apache/incubator-pegasus/pull/1597#discussion_r1538927914 ## src/replica/duplication/load_from_private_log.cpp: ## @@ -157,6 +159,7 @@ void load_from_private_log::find_log_file_to_start() error_s es = log

Re: [PR] fix(duplication): fix plog gc crash [incubator-pegasus]

2024-03-26 Thread via GitHub
empiredan commented on code in PR #1597: URL: https://github.com/apache/incubator-pegasus/pull/1597#discussion_r1538933903 ## src/replica/duplication/load_from_private_log.cpp: ## @@ -146,6 +146,8 @@ void load_from_private_log::run() void load_from_private_log::find_log_file

Re: [PR] fix(duplication): fix plog gc crash [incubator-pegasus]

2024-03-26 Thread via GitHub
empiredan commented on code in PR #1597: URL: https://github.com/apache/incubator-pegasus/pull/1597#discussion_r1538927914 ## src/replica/duplication/load_from_private_log.cpp: ## @@ -157,6 +159,7 @@ void load_from_private_log::find_log_file_to_start() error_s es = log

Re: [PR] fix(balance): Distinguish cluster balanced or collecting balance info interruptted [incubator-pegasus]

2024-03-26 Thread via GitHub
acelyc111 merged PR #1951: URL: https://github.com/apache/incubator-pegasus/pull/1951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pe

Re: [PR] fix(duplication): fix plog gc crash [incubator-pegasus]

2024-03-26 Thread via GitHub
empiredan commented on code in PR #1597: URL: https://github.com/apache/incubator-pegasus/pull/1597#discussion_r1538767939 ## src/replica/duplication/load_from_private_log.cpp: ## @@ -146,6 +146,8 @@ void load_from_private_log::run() void load_from_private_log::find_log_file