Re: [BUG FIX] Apache.xs write_client

2000-08-09 Thread T.J. Mather
no problem. i had thought that passing a reference to a scalar to Apache::print() provided a performance benefit: http://perl.apache.org/guide/porting.html#Apache_print_and_CORE_print_ and page 446 of the eagle book. from what i understand now, there is no actually no benefit to this, since Apa

Re: [BUG FIX] Apache.xs write_client

2000-08-09 Thread Ask Bjoern Hansen
On Wed, 9 Aug 2000, Doug MacEachern wrote: > > I'm not that comfortable with the perlguts, but it makes somewhat > > sense to me so I've committed it. > > there's already been enough argument that $r->print shouldn't dereference > anything. yeah, I agree. Actually, I didn't even remember that

Re: [BUG FIX] Apache.xs write_client

2000-08-09 Thread Ask Bjoern Hansen
On Wed, 9 Aug 2000, T.J. Mather wrote: I'm not that comfortable with the perlguts, but it makes somewhat sense to me so I've committed it. - ask > Hi, > > I have already posted this to [EMAIL PROTECTED]: > > I found and fixed a bug with Apache::print not dereferencing scalar > referencess th

[BUG FIX] Apache.xs write_client

2000-08-09 Thread T.J. Mather
Hi, I have already posted this to [EMAIL PROTECTED]: I found and fixed a bug with Apache::print not dereferencing scalar referencess that are of type SVt_PVIV. The patch is PATCH: --- Apache.xs.old Wed Aug 9 10:23:31 2000 +++ Apache.xs Wed Aug 9 10:23:13 2000 @@ -1076,7 +1076,7 @@