On Sat, 29 Sep 2001, Stas Bekman wrote:
>
> this patch:
> - implements modperl_table_get_set for other functions to use
> - implements Apache::Server::dir_config + tests
> - implements Apache::RequestRec::dir_config + tests
> - implements new features coming from modperl_table_get_set for free
>
this patch:
- implements modperl_table_get_set for other functions to use
- implements Apache::Server::dir_config + tests
- implements Apache::RequestRec::dir_config + tests
- implements new features coming from modperl_table_get_set for free
$(s|r)->dir_config($key => $val); # == set($key, $
Doug MacEachern wrote:
> On Sat, 29 Sep 2001, Stas Bekman wrote:
>
>
>>I've changed the map file, need to run source scan, but it doesn't work
>>:( back to manual...
>>
>>panic: not expecting 'tcpi_rcv_wscale' after array bounds in '
>> u_int8_t tcpi_snd_wscale : 4, tcpi_rcv_wscale : 4;'
>>E
On Sat, 29 Sep 2001, Stas Bekman wrote:
> but probably the whole function now should be moved elsewhere. if so
> then where?
modperl_util.[ch] will be fine.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional command
Doug MacEachern wrote:
> On Sat, 29 Sep 2001, Stas Bekman wrote:
>
>
>>I've implemented c) as it seems the most logical to me. Why? If you
>>*Set* some key/val in a subsection, you don't expect to inherit some
>>values for the same key from the parent section/dir. You do *Set*.
>>
>
> i see
On Sat, 29 Sep 2001, Stas Bekman wrote:
> the only question I've left is where to put the generic function? Should
> I keep it in Apache__RequestUtil.h?
as suggested before.. modperl_util.c
-
To unsubscribe, e-mail: [EMAIL
One more question: Now that we s/macro
TABLE_GET_SET/modperl_table_get_set/ where do I put the function
definition for xs/modperl_xs_util.h? I can do this:
SV *modperl_table_get_set(pTHX_ apr_table_t *table, char *key, SV *sv_val, bool
do_taint);
SV *modperl_table_get_set(pTHX_ apr_table_t *t
On Sat, 29 Sep 2001, Stas Bekman wrote:
> I've changed the map file, need to run source scan, but it doesn't work
> :( back to manual...
>
> panic: not expecting 'tcpi_rcv_wscale' after array bounds in '
>u_int8_t tcpi_snd_wscale : 4, tcpi_rcv_wscale : 4;'
> Expecting parenth after identifi
>>outstanding issues:
>>- ALIAS for Apache::Server::dir_config
>> Doug said: add the common function to modperl_util.c, then it can be
>> called from anywhere.
>> Stas replied: can you please be more verbose? what function?
>>
>
> the main body of dir_config, something like:
> SV *
I've changed the map file, need to run source scan, but it doesn't work
:( back to manual...
panic: not expecting 'tcpi_rcv_wscale' after array bounds in '
u_int8_t tcpi_snd_wscale : 4, tcpi_rcv_wscale : 4;'
Expecting parenth after identifier in `key=((void *)0)'
after `key' at /home/stas/per
On Sat, 29 Sep 2001, Stas Bekman wrote:
> I've implemented c) as it seems the most logical to me. Why? If you
> *Set* some key/val in a subsection, you don't expect to inherit some
> values for the same key from the parent section/dir. You do *Set*.
i see, that makes sense. should double che
Doug MacEachern wrote:
> On Fri, 28 Sep 2001, Stas Bekman wrote:
>
>
>>patch:
>>- this patch implements PerlSetVar and PerlAddVar
>>
>>changes:
>>- the first patch was broken, you cannot use apr_table_overlap for merging
>>SetVar tables(in merge_table_overlap_item) , because we want to overlap
> -Original Message-
> From: Doug MacEachern [mailto:[EMAIL PROTECTED]]
> Sent: Friday, September 28, 2001 10:30 AM
> To: Geoffrey Young
> Cc: '[EMAIL PROTECTED]'
> Subject: Re: bleedperl problems on 1.26-dev...
>
>
> On Fri, 28 Sep 2001, Geoffrey Young wrote:
>
> > hey...
> >
> >
On Fri, 28 Sep 2001, Geoffrey Young wrote:
> hey...
>
> did something happen to the bleedperl implementation of AUTOLOAD last
> night? my nightly recompile built ok, but the server won't start...
>
> [Fri Sep 28 07:32:36 2001] [error] Unable to create sub named "" at
> /src/modperl/blib/lib/
On Fri, 28 Sep 2001, Philippe M . Chiasson wrote:
> Aie ! There is a slight problem with this patch, as was pointed out by Stas a while
>ago.
>
> Blame it on the annoying TZ lag introduced in e-mail when living in Singapore ;-)
>
> This patch works, but doesn't preserve ARRAY context, thus:
o
On Fri, 28 Sep 2001, Stas Bekman wrote:
> patch:
> - implements Apache::RequestRec::dir_config 1.x compliance + allows:
> $r->dir_config($key => $val); # == set($key, $val)
> $r->dir_config($key => undef); # == unset($key)
> - adds tests for dir_config, PerlSetVar and PerlAddVar
nice.
> t
On Fri, 28 Sep 2001, Stas Bekman wrote:
> patch:
> - this patch implements PerlSetVar and PerlAddVar
>
> changes:
> - the first patch was broken, you cannot use apr_table_overlap for merging
> SetVar tables(in merge_table_overlap_item) , because we want to overlap
> only the values for the keys
Aie ! There is a slight problem with this patch, as was pointed out by Stas a while
ago.
Blame it on the annoying TZ lag introduced in e-mail when living in Singapore ;-)
This patch works, but doesn't preserve ARRAY context, thus:
my @list = $r->header_in("foo");
will not work ;(
On Fri, Sep
On Fri, 28 Sep 2001, Stas Bekman wrote:
> patch:
> - this patch implements the list context get
>
> changes:
> - fixing the args initialization (thanks gozer!)
good catch!
> - a few style fixes
> - a more extensive sub-test
looks great, +1
--
On Fri, 28 Sep 2001, Philippe M . Chiasson wrote:
> Here is a small patch to add $r->header_(in/out)() to Apache::compat
cool, thanks!
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTEC
On Fri, 28 Sep 2001, Philippe M . Chiasson wrote:
> Shouldn't it do something like
> if (magic_methcall(sv, mg, meth, GIMME_V, 2, NULL)) {
that would probably work, but i'm assuming G_SCALAR was used on purpose.
-
hey...
did something happen to the bleedperl implementation of AUTOLOAD last
night? my nightly recompile built ok, but the server won't start...
[Fri Sep 28 07:32:36 2001] [error] Unable to create sub named "" at
/src/modperl/blib/lib/Apache/Constants.pm line 23.
just FYI...
--Geoff
--
On Fri, Sep 28, 2001 at 06:45:07PM +0800, Stas Bekman wrote:
> patch:
> - this patch implements the list context get
Applied and tested fine
Only issue:
patching file t/response/TestAPR/table.pm
Hunk #3 FAILED at 72.
Hunk #4 FAILED at 87.
2 out of 4 hunks FAILED -- saving rejects to file t/resp
patch:
- implements Apache::RequestRec::dir_config 1.x compliance + allows:
$r->dir_config($key => $val); # == set($key, $val)
$r->dir_config($key => undef); # == unset($key)
- adds tests for dir_config, PerlSetVar and PerlAddVar
the problem I've solved:
- The use of 'items' in TABLE_GET_SET
patch:
- this patch implements PerlSetVar and PerlAddVar
changes:
- the first patch was broken, you cannot use apr_table_overlap for merging
SetVar tables(in merge_table_overlap_item) , because we want to overlap
only the values for the keys which arenot in the current dir_config table.
So I had
patch:
- this patch implements the list context get
changes:
- fixing the args initialization (thanks gozer!)
- a few style fixes
- a more extensive sub-test
Index: t/response/TestAPR/table.pm
===
RCS file: /home/cvs/modperl-2.0/t/r
26 matches
Mail list logo
