Re: current 'make test' status

2001-12-05 Thread Stas Bekman
On Thu, 6 Dec 2001, Stas Bekman wrote: > Doug MacEachern wrote: > > > On Wed, 5 Dec 2001, Stas Bekman wrote: > > > > > >>can we make the t/TEST use Apache-Test/lib rather than blib? I've run > >>'cvs up' but forgot to run 'make' to copy the updates to blib :( > >> > > > > i thought it already did

Re: more Apache::File compat issues

2001-12-05 Thread Stas Bekman
Stas Bekman wrote: > There are a few nits to solve with Apache::File compat: > > the same here: in fact this one is the opposite, the syntax in 2.0 is only $r->set_last_modified, with no args. > =item $r->set_last_modified() > > This method is used to set the outgoing Last-Modified head

more Apache::File compat issues

2001-12-05 Thread Stas Bekman
There are a few nits to solve with Apache::File compat: - $r->set_content_length doesn't support the call without args in 2.0 From File/File.pm: =item $r->set_content_length() This method sets the outgoing Content-length header based on its argument, which should be expressed in byte units.

Re: cvs commit: modperl-2.0/t/response/TestApache compat.pm

2001-12-05 Thread Stas Bekman
Doug MacEachern wrote: > On Thu, 6 Dec 2001, Stas Bekman wrote: > > >>But it's still not good for the compat layer. If a user doesn't have >>this setting it still core dumps with: >> >>t/TEST modules/cgi filter/input_msg apache/compat >> > > fixed with the "various bug fixes in the tls code"

Re: cvs commit: modperl-2.0/lib/Apache compat.pm

2001-12-05 Thread Stas Bekman
[EMAIL PROTECTED] wrote: > dougm 01/12/05 11:11:34 > > Modified:lib/Apache compat.pm > Log: > some whitespace style nits > remove redundant use of Apache::{Response,RequestRec} why they are redundant? is it sure that Apache::{Response,RequestRec} are always loaded? > -us

Re: current 'make test' status

2001-12-05 Thread Stas Bekman
Doug MacEachern wrote: > On Wed, 5 Dec 2001, Stas Bekman wrote: > > >>can we make the t/TEST use Apache-Test/lib rather than blib? I've run >>'cvs up' but forgot to run 'make' to copy the updates to blib :( >> > > i thought it already did: > t/TEST on the client does: > use lib map { "$_/Apa

Re: PerlIO::APR: getting the memory pool

2001-12-05 Thread Stas Bekman
Doug MacEachern wrote: > On Thu, 6 Dec 2001, Stas Bekman wrote: > > >>but I guess I don't understand something: why do we need to use >>APR::File->open? What's wrong with perl's open()? I've it working >>already. If you don't use perl's open() do you also imply that we have >>to use $fh->cl

Re: current 'make test' status

2001-12-05 Thread Doug MacEachern
On Wed, 5 Dec 2001, Stas Bekman wrote: > can we make the t/TEST use Apache-Test/lib rather than blib? I've run > 'cvs up' but forgot to run 'make' to copy the updates to blib :( i thought it already did: t/TEST on the client does: use lib map { "$_/Apache-Test/lib" } qw(. ..); and t/conf/modp

Re: cvs commit: modperl-2.0/t/response/TestApache compat.pm

2001-12-05 Thread Doug MacEachern
On Thu, 6 Dec 2001, Stas Bekman wrote: > But it's still not good for the compat layer. If a user doesn't have > this setting it still core dumps with: > > t/TEST modules/cgi filter/input_msg apache/compat fixed with the "various bug fixes in the tls code" commit. -

Re: PerlIO::APR: getting the memory pool

2001-12-05 Thread Doug MacEachern
On Thu, 6 Dec 2001, Stas Bekman wrote: > but I guess I don't understand something: why do we need to use > APR::File->open? What's wrong with perl's open()? I've it working > already. If you don't use perl's open() do you also imply that we have > to use $fh->close, $fh->seek and so on, using

Re: PerlIO::APR: getting the memory pool

2001-12-05 Thread Stas Bekman
Doug MacEachern wrote: > On Tue, 4 Dec 2001, Stas Bekman wrote: > > >>I'm implementing PerlIO::APR (will be APR::IO in mod_perl) >> >>I need to get my hands on the memory pool. Currently I use the global >>pool via modperl_global_get_pconf(). which allows you to keep your code >>as a pure per

Re: cvs commit: modperl-2.0/t/response/TestApache compat.pm

2001-12-05 Thread Stas Bekman
Stas Bekman wrote: > [EMAIL PROTECTED] wrote: > >> stas01/12/04 21:31:09 >> >> Modified:lib/Apache compat.pm >>t/apache compat.t >>t/response/TestApache compat.pm >> Log: >> - the implementation of compatibility layer for Apache::File from 1.x >>

RE: porting Apache::File issues

2001-12-05 Thread Geoffrey Young
> > nice. but that doesn't give you a filename like > Apache::File->tmpfile > > does, so we'd still need the old code for Apache::compat. > > > why do you want to know the filename? > my ($filename, $fh) = Apache::File->tmpfile; ... $r->set_content_length(-s $filename); :) --Geof

Re: cvs commit: modperl-2.0/t/response/TestApache compat.pm

2001-12-05 Thread Stas Bekman
[EMAIL PROTECTED] wrote: > stas01/12/04 21:31:09 > > Modified:lib/Apache compat.pm >t/apache compat.t >t/response/TestApache compat.pm > Log: > - the implementation of compatibility layer for Apache::File from 1.x > - tests Any ideas why tmpf