Re: [mp2] Win32 problems

2003-04-03 Thread Randy Kobes
On Fri, 4 Apr 2003, Stas Bekman wrote: > Hmm, I still think that my mips init move wasn't complete. > Please try this patch first: > > Index: src/modules/perl/mod_perl.c > === > RCS file: /home/cvs/modperl-2.0/src/modules/perl/mod_pe

Re: bleedperl crypt_buffer changes

2003-04-03 Thread Stas Bekman
Geoffrey Young wrote: ok, I figured it out. the relevant change is http://mirrors.develooper.com/perl/APC/perl-current-diffs/19122.gz and my previous patch dumped core. here's a new one. Thanks Geoff, however the fix, shouldn't be yet another workaround, but just adding a patch level check for

what's the equiv of PERL_PATCHLEVEL in the public defines API?

2003-04-03 Thread Stas Bekman
In mod_perl 2.0 we had to patch the 5.8.0's bug related to crypt_r. Similar to this patch http://mirrors.develooper.com/perl/APC/perl-current-diffs/17775.gz. However the recent changes #19119 (maint) and #19122 (blead) broke mod_perl 2.0's build. So we need to put something like: #if PERL_PATCH

Re: [mp2] Win32 problems

2003-04-03 Thread Stas Bekman
Randy Kobes wrote: On Mon, 31 Mar 2003, Stas Bekman wrote: Randy Kobes wrote: - secondly, there's a problem in starting the tests, with a free to a wrong pool and then an access violation in the perl58 lib. I've just built the worker on linux, but haven't seen any problems. I think the only ch

Re: adding usage to all XS wrappers

2003-04-03 Thread Nick Tonkin
On Fri, 4 Apr 2003, Stas Bekman wrote: > Nick Tonkin wrote: > > On Fri, 4 Apr 2003, Stas Bekman wrote: > > > > > >>[moving to the dev list] > >> > >>Nick Tonkin wrote: > >>[...] > >> > Working on finishing the rewrite of porting.pod. In the above example, the > >> > error mesage emitted is: > >> >

Re: adding usage to all XS wrappers

2003-04-03 Thread Stas Bekman
Nick Tonkin wrote: On Fri, 4 Apr 2003, Stas Bekman wrote: [moving to the dev list] Nick Tonkin wrote: [...] > Working on finishing the rewrite of porting.pod. In the above example, the > error mesage emitted is: > > [Thu Apr 03 06:43:24 2003] [error] [client 192.168.0.33] p is not of type > APR:

Re: adding usage to all XS wrappers

2003-04-03 Thread Nick Tonkin
On Fri, 4 Apr 2003, Stas Bekman wrote: > [moving to the dev list] > > Nick Tonkin wrote: > [...] > > Working on finishing the rewrite of porting.pod. In the above example, the > > error mesage emitted is: > > > > [Thu Apr 03 06:43:24 2003] [error] [client 192.168.0.33] p is not of type > > AP

adding usage to all XS wrappers

2003-04-03 Thread Stas Bekman
[moving to the dev list] Nick Tonkin wrote: [...] > Working on finishing the rewrite of porting.pod. In the above example, the > error mesage emitted is: > > [Thu Apr 03 06:43:24 2003] [error] [client 192.168.0.33] p is not of type > APR::Pool at /home/debug/www/_perl/NPT/MyTest.pm line 9. > > Thi

Re: [patch] ModPerl::BuildMM and Apache2

2003-04-03 Thread Stas Bekman
Geoffrey Young wrote: (this is kinda verbose. jumping to the patch at the end is probably just as clear :) ok, while trying to track down the filter remove problem I removed all traces of mod_perl 2.0 from perl's @INC - everything under Apache2/ as well as Apache2.pm and all the Apache::Test s

Re: running Apache::Test tests

2003-04-03 Thread Stas Bekman
So -0 here. that's fine. the only situation where I would be more inclined to include them is if we could run them first, making it easier to isolate errors due to broken Apache::Test libraries rather then core mod_perl. but, as we both agree, running the tests is really overkill. We can al

Re: running Apache::Test tests

2003-04-03 Thread Geoffrey Young
Stas Bekman wrote: Geoffrey Young wrote: I never noticed it before, but 'make test' runs mod_perl core tests and ModPerl::Registry tests, but not Apache::Test tests. I kinda think we should be running all available tests, especially for software we're installing alongside mod_perl (even thou

Re: $mod_perl::VERSION vs. Apache::exists_config_define("MODPERL2")

2003-04-03 Thread Stas Bekman
Nick Tonkin wrote: Any preference between these two methods of finding out what version of mod_perl we are running under? And should we document both in the porting tutorial, or is it better to just pick one? We need both. $mod_perl::VERSION tells you the exact version. And it can be queried by an

Re: running Apache::Test tests

2003-04-03 Thread Stas Bekman
Geoffrey Young wrote: I never noticed it before, but 'make test' runs mod_perl core tests and ModPerl::Registry tests, but not Apache::Test tests. I kinda think we should be running all available tests, especially for software we're installing alongside mod_perl (even though it's a little backw

running Apache::Test tests

2003-04-03 Thread Geoffrey Young
I never noticed it before, but 'make test' runs mod_perl core tests and ModPerl::Registry tests, but not Apache::Test tests. I kinda think we should be running all available tests, especially for software we're installing alongside mod_perl (even though it's a little backwards, testing Apache:

Porting tutorial

2003-04-03 Thread Nick Tonkin
Hi folks, here's a rewrite of the porting.pod tutorial. Comments welcome. - nick -- Nick Tonkin {|8^)> =head1 NAME - Porting Apache:: Modules from mod_perl 1.0 to 2.0 =head1 Description This document describes the various options for porting a mod_perl 1.0 Apache modu

$mod_perl::VERSION vs. Apache::exists_config_define("MODPERL2")

2003-04-03 Thread Nick Tonkin
Any preference between these two methods of finding out what version of mod_perl we are running under? And should we document both in the porting tutorial, or is it better to just pick one? - nick -- Nick Tonkin {|8^)> -