Re: cvs commit: modperl-2.0/xs/Apache/Module Apache__Module.h

2003-05-30 Thread Geoffrey Young
[EMAIL PROTECTED] wrote: geoff 2003/05/30 06:39:44 Modified:xs/Apache/Module Apache__Module.h Log: sorry, committed a change in progress. really sorry. I'm really sorry about this. I forgot to commit the new directory and file for the $parms->info() stuff, but in the meanwhile

Re: $parms->info(), take 2

2003-05-30 Thread Geoffrey Young
all those *.h files are full of both mpxs_ functions and static XS functions, with functionaity implemented in one or the other seemingly at random. I have no idea how you would choose one format over the other, but if the mpxs_ implementation makes you more comfortable, that's fine - I'll co

Re: SizeLimit patch

2003-05-30 Thread Perrin Harkins
On Fri, 2003-05-30 at 01:26, Stas Bekman wrote: > That's correct, currently you have the commit access only to the modperl-docs > rep. Okay, no problem. I'll be updating some stuff there soon too, hopefully. > In the future please submit a separte patch per feature change, not per file ;) Oops

Re: SizeLimit patch

2003-05-30 Thread Philippe M. Chiasson
On Fri, 2003-05-30 at 13:26, Stas Bekman wrote: > Perrin Harkins wrote: > > I have a patch for Apache::SizeLimit which I'd like to get into the 1.28 > > build, but CVS is not cooperating with me. I guess I don't have > > permission to update the modperl tree. > > That's correct, currently you hav

Re: SizeLimit patch

2003-05-30 Thread Stas Bekman
Perrin Harkins wrote: I have a patch for Apache::SizeLimit which I'd like to get into the 1.28 build, but CVS is not cooperating with me. I guess I don't have permission to update the modperl tree. That's correct, currently you have the commit access only to the modperl-docs rep. Thanks, commite

SizeLimit patch

2003-05-30 Thread Perrin Harkins
I have a patch for Apache::SizeLimit which I'd like to get into the 1.28 build, but CVS is not cooperating with me. I guess I don't have permission to update the modperl tree. Can someone commit this for me? I'm attaching a SizeLimit patch and a patch to Changes that describes it. - Perrin ---

mp2: segfault in make test on sun4-solaris

2003-05-30 Thread Stas Bekman
[cc: changing a subject to something more suitable] Tulan W. Hu wrote: First let's get in sync: Are you using the latest cvs? or mod_perl 1.99? I need to fix the bug report script to include that info. Now you need to rebuild perl with debug support (using flags -Doptimize='-g' -Dusedevel) so th

Re: mp2.0 - make test failed cgi.t

2003-05-30 Thread Batara Kesuma
Hi Ian, On Tue, 27 May 2003 13:07:14 -0700 Ian Holsman <[EMAIL PROTECTED]> wrote: > I just got the same error on my machine. > perl 5.6.1/CGI.pm 2.7x > > I upgraded the CGI to 2.93 and it passed through the test. Thanks, its the same here. Upgraded and passed the test. ---

Fw: sorry to send this to your email address

2003-05-30 Thread Tulan W. Hu
- Original Message - From: "Stas Bekman" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Sunday, May 25, 2003 4:16 AM Subject: Re: sorry to send this to your email address > [EMAIL PROTECTED] wrote: > > Since I just cannot find the email address > > that I suppose to sent. > > please l

Re: mp2.0 - make test failed compat/apache_util.t

2003-05-30 Thread Batara Kesuma
Hi Stas, > glib uses LC_ env vars. This is from the bash manpage: > > LANG Used to determine the locale category for any > category not >specifically selected with a variable starting with LC_. > LC_ALL This variable overrides the value of LANG

Re: mp2.0 - make test failed compat/apache_util.t

2003-05-30 Thread Batara Kesuma
Hi Stas, > You don't need to recompile with LANG=en_US, it's a run-time setting. > > However I'll need your help to resolve this for all those who have a > different LC setting. BTW, according to strftime it's LC_TIME env var > that matters. or is LANG affecting all other LC_* env vars? How can

Re: mp2.0 - make test failed compat/apache_util.t

2003-05-30 Thread Batara Kesuma
Hi Stas, > You forgot to paste the output of the t/TEST -v run (in addition to > t/logs/error_log). I thought I made that clear at: > http://perl.apache.org/docs/2.0/user/help/help.html#_C_make_test___Failures > Please suggest how to make that even clearer. Thanks. Wow that

mp2.0 - make test failed compat/apache_util.t

2003-05-30 Thread Batara Kesuma
Hi Stas, > > Failed Test Stat Wstat Total Fail Failed List of Failed > > - > > -- > > compat/apache_util.t 151 6.67% 13 > > Please follow these guidelines to report problems with 'make test

Re: $parms->info(), take 2

2003-05-30 Thread Stas Bekman
Geoffrey Young wrote: +static XS(MPXS_Apache__CmdParms_info) All you need is: SV *mpxs_Apache__CmdParms_info(pTHX_ cmd_params* cmd_parms) this is untested, but should give you an idea. of course you need to adjust the map file and Functions.pm. Doesn't it look much simpler? all those *.h

Re: $parms->info(), take 2

2003-05-30 Thread Geoffrey Young
+static XS(MPXS_Apache__CmdParms_info) All you need is: SV *mpxs_Apache__CmdParms_info(pTHX_ cmd_params* cmd_parms) this is untested, but should give you an idea. of course you need to adjust the map file and Functions.pm. Doesn't it look much simpler? all those *.h files are full of both mpx

Re: $parms->info(), take 2

2003-05-30 Thread Stas Bekman
> also included is adding the -u flag to part of getdiff.pl. I know > that's not platform independent, but -u was used elsewhere in getdiff.pl > and I'm sure you don't want people sending in non-unified diffs :) +1, but commit it separately. We all have ~/.cvsrc with diff -u so we didn't notice t

$parms->info(), take 2

2003-05-30 Thread Geoffrey Young
ok, here is an updated patch, with the XS cleaned up a bit. the important change between this version and the last is that $parms->info() is now read-only. I couldn't think of a case where you would want to write to the info slot, and doing so would just cause erroneous results - since directiv