Re: cvs commit: modperl-2.0/t/hooks cleanup2.t

2003-06-06 Thread Randy Kobes
On Fri, 6 Jun 2003, Stas Bekman wrote: > Randy please test my latest commit. It should just work, now > that it does the right thing ;) Hi Stas, Works fine now - thanks! -- best regards, randy - To unsubscribe, e-mail: [EM

Re: a new stacked handlers paradigm

2003-06-06 Thread Geoffrey Young
would those MP_ constants be helpful, such as MP_HANDLER_TYPE_PER_DIR and MP_HEADER_PARSER_HANDLER? it's hard to tell without working on an implementation. You mean using define constants, instead of enums? Or do you suggest to move defines into this struct? just placing the define values in

Re: [mp1] Segfautl with constant handlers and perl 5.6.x

2003-06-06 Thread Stas Bekman
Philippe M. Chiasson wrote: I've narrowed down a strange bug I reported a while back. Seems that using constant for Perl* directives doesn't quite work for perl 5.6.1 and 5.6.x PerlModule Apache::Constants SetHandler perl-script PerlHandler Apache::OK #0 0x0816df79 in ?? () #1 0x400a38c7

Re: a new stacked handlers paradigm

2003-06-06 Thread Stas Bekman
Geoffrey Young wrote: Something like that (again just an idea). Perhaps we should really create a struct: typedef enum { VOID, RUN_FIRST, RUN_ALL } modperl_hook_run_mode_e struct modperl_hook_t { const char *desc; modperl_hook_run_mode_e run_mode; }; and now we can kill all th

Re: VOID => RUN_ALL or what?

2003-06-06 Thread Stas Bekman
Geoffrey Young wrote: while I tend to want to follow the apache specs closely, I'm not sure about this. the standard mod_perl meme is to always return a value from a handler - by letting ignoring the return value of these and letting the request proceed we're loosing functionality. for instan

Re: [Fwd: Re: [rfc] APR::Table & polymorphic values]

2003-06-06 Thread Stas Bekman
Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: The solution I see is to store the id in the key, so when FETCH is called in the SCALAR context it checks whether the key has an id and uses it to get the appropriate value. Otherwise it calls apr_table_get(). Does this work? It just m

Re: [Fwd: Re: [rfc] APR::Table & polymorphic values]

2003-06-06 Thread Joe Schaefer
Stas Bekman <[EMAIL PROTECTED]> writes: > The solution I see is to store the id in the key, so when FETCH is > called in the SCALAR context it checks whether the key has an id and > uses it to get the appropriate value. Otherwise it calls > apr_table_get(). Does this work? It just might. Try fid

Re: [mp2] t/hooks/cleanup2.t on Win32

2003-06-06 Thread Stas Bekman
Randy Kobes wrote: Hi, The t/hooks/cleanup2.t test in mp2 uses an explicit value for the size of a file, which isn't the right value for Win32, due to crlf differences. This diff: == Index: cleanup2.t ===

Re: [Fwd: Re: [rfc] APR::Table & polymorphic values]

2003-06-06 Thread Stas Bekman
Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: [...] Check this out. It seems to work now. Here is a complete patch. You will have to rebuild the whole thing, because of the API change. [...] +static MP_INLINE +const char *mpxs_APR__Table_FETCH(pTHX_ SV *tsv, const char *key) +{

Re: rfc: adding a bootstrap magic check to mp2 DSO libs

2003-06-06 Thread Stas Bekman
Geoffrey Young wrote: we could md5 the perl binary? eeck! what about computing an MD5 hash of various attributes of both perl and mod_perl - combine a few important bits from $Config the important version and compile options from mod_perl/apache? Sure, we need to compile a list of options th

Re: a new stacked handlers paradigm

2003-06-06 Thread Geoffrey Young
Something like that (again just an idea). Perhaps we should really create a struct: typedef enum { VOID, RUN_FIRST, RUN_ALL } modperl_hook_run_mode_e struct modperl_hook_t { const char *desc; modperl_hook_run_mode_e run_mode; }; and now we can kill all the modperl_handler_desc

Re: VOID => RUN_ALL or what?

2003-06-06 Thread Geoffrey Young
while I tend to want to follow the apache specs closely, I'm not sure about this. the standard mod_perl meme is to always return a value from a handler - by letting ignoring the return value of these and letting the request proceed we're loosing functionality. for instance, filters would no l

Re: [Fwd: Re: [rfc] APR::Table & polymorphic values]

2003-06-06 Thread Joe Schaefer
Stas Bekman <[EMAIL PROTECTED]> writes: [...] > Check this out. It seems to work now. Here is a complete patch. > You will have to rebuild the whole thing, because of the API change. [...] > +static MP_INLINE > +const char *mpxs_APR__Table_FETCH(pTHX_ SV *tsv, const char *key) > +{ > +apr_t

Re: cvs commit: modperl/t/docs/auth .htaccess

2003-06-06 Thread Philippe M. Chiasson
On Fri, 2003-06-06 at 15:40, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > On Thu, 2003-06-05 at 15:16, Stas Bekman wrote: > > > >>[EMAIL PROTECTED] wrote: > >> > >>>gozer 2003/06/05 00:09:20 > >>> > >>> Modified:.Makefile.PL > >>> t/docs/auth .htaccess > >>

Re: rfc: adding a bootstrap magic check to mp2 DSO libs

2003-06-06 Thread Geoffrey Young
we could md5 the perl binary? eeck! what about computing an MD5 hash of various attributes of both perl and mod_perl - combine a few important bits from $Config the important version and compile options from mod_perl/apache? --Geoff ---

[mp2] t/hooks/cleanup2.t on Win32

2003-06-06 Thread Randy Kobes
Hi, The t/hooks/cleanup2.t test in mp2 uses an explicit value for the size of a file, which isn't the right value for Win32, due to crlf differences. This diff: == Index: cleanup2.t ==

Re: Objections to a mp-1.28 release candidate ?

2003-06-06 Thread Geoffrey Young
Also, one last thing of importance I guess, is anybody seeing test failures with current CVS of any platform ? my RH box passes ok with bleadperl against httpd cvs. --Geoff - To unsubscribe, e-mail: [EMAIL PROTECTED] For addit

Re: cvs commit: modperl/t/docs/auth .htaccess

2003-06-06 Thread Stas Bekman
Philippe M. Chiasson wrote: On Thu, 2003-06-05 at 15:16, Stas Bekman wrote: [EMAIL PROTECTED] wrote: gozer 2003/06/05 00:09:20 Modified:.Makefile.PL t/docs/auth .htaccess Log: s/Apache::(OK|DECLINED)/Apache::Constants::$1/g argh, now that I looked in eagle: ch0

Re: cvs commit: modperl/t/docs/auth .htaccess

2003-06-06 Thread Philippe M. Chiasson
On Thu, 2003-06-05 at 15:16, Stas Bekman wrote: > [EMAIL PROTECTED] wrote: > > gozer 2003/06/05 00:09:20 > > > > Modified:.Makefile.PL > >t/docs/auth .htaccess > > Log: > > s/Apache::(OK|DECLINED)/Apache::Constants::$1/g > > argh, now that I looked in eagle

Re: rfc: adding a bootstrap magic check to mp2 DSO libs

2003-06-06 Thread Stas Bekman
Philippe M. Chiasson wrote: On Fri, 2003-06-06 at 01:08, Geoffrey Young wrote: we could md5 the perl binary? eeck! what about computing an MD5 hash of various attributes of both perl and mod_perl - combine a few important bits from $Config the important version and compile options from mod_per

Re: rfc: adding a bootstrap magic check to mp2 DSO libs

2003-06-06 Thread Philippe M. Chiasson
On Fri, 2003-06-06 at 01:08, Geoffrey Young wrote: > > we could md5 the perl binary? > > eeck! > > what about computing an MD5 hash of various attributes of both perl and > mod_perl - combine a few important bits from $Config the important version > and compile options from mod_perl/apache? I