Re: [mp2] including a Win32 apxs?

2003-11-06 Thread Randy Kobes
On Thu, 6 Nov 2003, Stas Bekman wrote: > Randy Kobes wrote: > very neat! A few more comments: > > > = > > Index: Makefile.PL > > === > [...] > > +sub fetch_apxs { > > +my $pr

[mp2] failing getppid test with 5.8.0

2003-11-06 Thread Stas Bekman
Scott gets the getppid test failing with mp2-cvs/5.8.0 but I can't reproduce it. I think this is because RH ships a fake 5.8.0. It says MAINT18379 which dates 27 Dec 2002 (5 months after 5.8.0 was released) http://public.activestate.com/cgi-bin/perlbrowse?patch=18379 This problem shouldn't have h

Re: [mp2] including a Win32 apxs?

2003-11-06 Thread Stas Bekman
Randy Kobes wrote: very neat! A few more comments: = Index: Makefile.PL === [...] +sub fetch_apxs { +my $prefix = $build->{MP_AP_PREFIX} || ''; +my $script = catfile($buil

Re: [mp2] modperl_request_read in mod_perl.lib

2003-11-06 Thread Stas Bekman
Randy Kobes wrote: With the current mp2 cvs, the build of Apache::RequestIO fails with an unknown symbol modperl_request_read on Win32. I think this is due to modperl_request_read being declared as static within xs/tables/current/ModPerl/FunctionTable.pm, which as such doesn't get added to mod_perl

[mp2] modperl_request_read in mod_perl.lib

2003-11-06 Thread Randy Kobes
With the current mp2 cvs, the build of Apache::RequestIO fails with an unknown symbol modperl_request_read on Win32. I think this is due to modperl_request_read being declared as static within xs/tables/current/ModPerl/FunctionTable.pm, which as such doesn't get added to mod_perl.lib. This patch: =

Re: [mp2] including a Win32 apxs?

2003-11-06 Thread Randy Kobes
On Thu, 6 Nov 2003, Stas Bekman wrote: [...] > > +sub fetch_apxs { > > +my $prefix = $build->{MP_AP_PREFIX}; > > are you sure it's always set to a sensible value? That's a good point - the diff below will check that. Thanks. > > +return if -e catfile($prefix, 'bin', 'apxs.bat1'); > > I s

Re: How to detect client disconnect without doing any I/O in mod_perl2?

2003-11-06 Thread Stas Bekman
Alex Khrenov wrote: In the mod_perl1 there is $c->fileno( [$direction] ) for it. How can i to do in mod_perl2? $c->aborted? Though I'm not sure whether it'll be set if you don't try to read from/write to the socket. It'd be nice to add such a test to our test suite. Patches are *very* welcome. _

Re: [mp2] including a Win32 apxs?

2003-11-06 Thread Stas Bekman
Randy Kobes wrote: [...] If not, perhaps we should just bundle it with mod_perl? Or would it be a bad idea? The fetch thing sounds OK, but what if the there is no network available during the install? Also some people won't like "random" code being brought and installed without them reviewing it fi

How to detect client disconnect without doing any I/O in mod_perl2?

2003-11-06 Thread Alex Khrenov
In the mod_perl1 there is $c->fileno( [$direction] ) for it. How can i to do in mod_perl2? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [mp2] including a Win32 apxs?

2003-11-06 Thread Randy Kobes
On Wed, 5 Nov 2003, Stas Bekman wrote: > Randy Kobes wrote: > > Hi, > > I was wondering how it would be felt to include an offer > > in mp2 to get a Win32 version of apxs, if this was not > > detected. There's a tar.gz archive on perl.apache.org that > > contains this (plus apr-config and apu-co