RE: BUG REPORT: mod_perl2 installation bug on failed apr-ext/uuid.t test

2004-02-09 Thread Jeff Beer
Geoffrey, I did three things: 1. I wasn't sure my apache had --with-mpm=prefork so I rebuilt it with that. 2. I am now using: modperl-2.0_20040208052306.tar.gz 3. Not being the 1st time with the above distribution, I did make clean, chowned everything else to a non-root account, and ran it again.

Re: cvs commit: modperl-2.0 Changes

2004-02-09 Thread Geoffrey Young
>> I guess I was looking for a handler configured with >> PerlOutputFilterHandler >> to return 'PerlOuputFilterHandler' for $r->current_callback, not >> 'PerlResponseHandler' which is clearly a different thing. >> >> but yes, I see your point that it's the response phase nonetheless. so, >> maybe

Re: cvs commit: modperl-2.0 Changes

2004-02-09 Thread Stas Bekman
Geoffrey Young wrote: for sure output filters are getting PerlResponseHandler, which is clearly a bug, but not one that is easily fixed. it depends on how do you look at it. I think it's a goodness to know inside a filter what phase is it running in. So I don't mind making filters different than

Re: cvs commit: modperl-2.0 Changes

2004-02-09 Thread Geoffrey Young
>> for sure output filters are getting PerlResponseHandler, which is >> clearly a bug, but not one that is easily fixed. > > > it depends on how do you look at it. I think it's a goodness to know > inside a filter what phase is it running in. So I don't mind making > filters different than any o

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in perlsection.conf

2004-02-09 Thread Stas Bekman
Philippe M. Chiasson wrote: What's the advantage of using A::TC::writefile instead ? It doesn't cleanup the files and doesn't log what it does. I see no reason why would you want to delete it. t_write_file is for the test run-time. I can't really call Apache::TestConfig->new from within the se

Re: cvs commit: modperl-2.0 Changes

2004-02-09 Thread Stas Bekman
Geoffrey Young wrote: Anything that's running before the content handler, will not have modperl_callback_current_callback_get() return "PerlResponseHandler", no? I think that's the way it ought to be, yes :) but I think that the way filter_init is currently implemented is getting PerlResponseHan

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in perlsection.conf

2004-02-09 Thread Philippe M. Chiasson
On Mon, 2004-02-09 at 16:38 -0800, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > On Mon, 2004-02-09 at 15:15 -0800, Stas Bekman wrote: > > > >>[EMAIL PROTECTED] wrote: > >> > >>>gozer 2004/02/09 14:20:53 > >>> > >>> Modified:t/conf extra.last.conf.in > >>> Removed: t/conf

Re: [mp2] read/write access to server/process records (+patches)

2004-02-09 Thread Stas Bekman
Geoffrey Young wrote: in general, I don't agree with this - modifying several of the server_rec slots at request time is something that some (few) mp1 user required. Did they wanted to affect the server for the future requests, or just the current request? the only value I see is in scoping ser

Re: [mp2] splitting the test suite into several smaller ones

2004-02-09 Thread Stas Bekman
Philippe M. Chiasson wrote: On Mon, 2004-02-09 at 15:20 -0800, Stas Bekman wrote: I've planned to post it here for discussion first Well, I think it's an idea that has a lot of value++ At least, provide a way to group tests together in categories and have them each configure/start/stop the

Re: cvs commit: modperl-2.0 Changes

2004-02-09 Thread Geoffrey Young
> Anything that's running before the content handler, will not have > modperl_callback_current_callback_get() return "PerlResponseHandler", no? I think that's the way it ought to be, yes :) but I think that the way filter_init is currently implemented is getting PerlResponseHandler. at least th

Re: [mp2] read/write access to server/process records (+patches)

2004-02-09 Thread Geoffrey Young
>> in general, I don't agree with this - modifying several of the server_rec >> slots at request time is something that some (few) mp1 user required. > > > Did they wanted to affect the server for the future requests, or just > the current request? > the only value I see is in scoping server_r

Re: mp2 acl support?

2004-02-09 Thread Stas Bekman
Philippe M. Chiasson wrote: [...] So I guess it would be safe to use filetest 'access' in ModPerl-Registry (at least on Linux), but I would worry about: 1. Other Uni*es and Win32 What about them? Well, from a glance at pp_sys.c, it seems that Perl will do the right thing and use access() if it's

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in perlsection.conf

2004-02-09 Thread Stas Bekman
Philippe M. Chiasson wrote: On Mon, 2004-02-09 at 15:15 -0800, Stas Bekman wrote: [EMAIL PROTECTED] wrote: gozer 2004/02/09 14:20:53 Modified:t/conf extra.last.conf.in Removed: t/conf perlsection.conf Log: To test recursive/re-entrant sections, autogenerate the included fi

Re: cvs commit: modperl-2.0 Changes

2004-02-09 Thread Stas Bekman
Geoffrey Young wrote: How does it get affected? When you are inside request filters you are already inside a response phase. filter_init runs before the content handler - I would expect to be able to set r->handler to whatever I want up until r->handler is actually invoked. Anything that's runni

Re: [mp2] splitting the test suite into several smaller ones

2004-02-09 Thread Philippe M. Chiasson
On Mon, 2004-02-09 at 15:20 -0800, Stas Bekman wrote: > I've planned to post it here for discussion first > Well, I think it's an idea that has a lot of value++ At least, provide a way to group tests together in categories and have them each configure/start/stop the server. I am all in favo

Re: mp2 acl support?

2004-02-09 Thread Philippe M. Chiasson
On Mon, 2004-02-09 at 14:47 -0800, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > On Sun, 2004-02-08 at 04:03 -0500, Andres Salomon wrote: > > > >>Hi Stas, > >> > >>I was wondering about the status of ACL support for modperl2. The > >>following two urls contain info and patches: > >> > >>ht

Re: cvs commit: modperl STATUS

2004-02-09 Thread Philippe M. Chiasson
On Mon, 2004-02-09 at 14:41 -0800, Stas Bekman wrote: > [EMAIL PROTECTED] wrote: > > gozer 2004/02/09 14:30:07 > > > > Modified:.STATUS > > Log: > > Record the patch+thread about correctly detecting if a script is > > executable when filesystem ACLs are being used. > > b

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in perlsection.conf

2004-02-09 Thread Philippe M. Chiasson
On Mon, 2004-02-09 at 15:15 -0800, Stas Bekman wrote: > [EMAIL PROTECTED] wrote: > > gozer 2004/02/09 14:20:53 > > > > Modified:t/conf extra.last.conf.in > > Removed: t/conf perlsection.conf > > Log: > > To test recursive/re-entrant sections, autogenerate the included fi

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in perlsection.conf

2004-02-09 Thread Philippe M. Chiasson
On Mon, 2004-02-09 at 14:35 -0800, Stas Bekman wrote: > [EMAIL PROTECTED] wrote: > > gozer 2004/02/09 14:20:53 > > > > Modified:t/conf extra.last.conf.in > [...] > >#Handle re-entrant sections > > > > -$Include = "@ServerRoot@/conf/perlsection.conf"; > > require File::Spe

Re: cvs commit: modperl-2.0 Changes

2004-02-09 Thread Geoffrey Young
> How does it get affected? When you are inside request filters you are > already inside a response phase. filter_init runs before the content handler - I would expect to be able to set r->handler to whatever I want up until r->handler is actually invoked. --Geoff

[mp2] splitting the test suite into several smaller ones

2004-02-09 Thread Stas Bekman
I've planned to post it here for discussion first Index: tests === ## # test suite issues and improvements # ## - As the number of tests grows it

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in perlsection.conf

2004-02-09 Thread Stas Bekman
[EMAIL PROTECTED] wrote: gozer 2004/02/09 14:20:53 Modified:t/conf extra.last.conf.in Removed: t/conf perlsection.conf Log: To test recursive/re-entrant sections, autogenerate the included file instead of having to keep t/conf/perlsection.conf in CVS Revision Cha

Re: mp2 acl support?

2004-02-09 Thread Stas Bekman
Philippe M. Chiasson wrote: On Sun, 2004-02-08 at 04:03 -0500, Andres Salomon wrote: Hi Stas, I was wondering about the status of ACL support for modperl2. The following two urls contain info and patches: http://www.gossamer-threads.com/archive/mod_perl_C1/modperl_F7/%5BPATCH%5D_acl_support_P582

Re: cvs commit: modperl STATUS

2004-02-09 Thread Stas Bekman
[EMAIL PROTECTED] wrote: gozer 2004/02/09 14:30:07 Modified:.STATUS Log: Record the patch+thread about correctly detecting if a script is executable when filesystem ACLs are being used. but this patch is not good, since it modifies all the calls to use POSIX::access, ins

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in perlsection.conf

2004-02-09 Thread Stas Bekman
[EMAIL PROTECTED] wrote: gozer 2004/02/09 14:20:53 Modified:t/conf extra.last.conf.in [...] #Handle re-entrant sections -$Include = "@ServerRoot@/conf/perlsection.conf"; require File::Spec; missing? +my $file = File::Spec->catfile('@ServerRoot@', 'conf', 'perlsectio

[Patch mp2] Was : mp2 acl support?

2004-02-09 Thread Philippe M. Chiasson
On Sun, 2004-02-08 at 04:03 -0500, Andres Salomon wrote: > Hi Stas, > > I was wondering about the status of ACL support for modperl2. The > following two urls contain info and patches: > > http://www.gossamer-threads.com/archive/mod_perl_C1/modperl_F7/%5BPATCH%5D_acl_support_P58252/ > http://bug

Re: [mp2] read/write access to server/process records (+patches)

2004-02-09 Thread Stas Bekman
Geoffrey Young wrote: Stas Bekman wrote: I'm trying to resolve two related items in todo/release: The first step: provide support for read-only structure accessors, made all perl server_rec and process_rec accessors read-only (the patch is below). I agree with most of this, save certain attrib

Re: mp2 acl support?

2004-02-09 Thread Philippe M. Chiasson
On Sun, 2004-02-08 at 04:03 -0500, Andres Salomon wrote: > Hi Stas, > > I was wondering about the status of ACL support for modperl2. The > following two urls contain info and patches: > > http://www.gossamer-threads.com/archive/mod_perl_C1/modperl_F7/%5BPATCH%5D_acl_support_P58252/ > http://bug

Re: [mp2] moving t/conf/perlsection.conf elsewhere?

2004-02-09 Thread Philippe M. Chiasson
On Mon, 2004-02-09 at 13:23 -0800, Stas Bekman wrote: > > On Mon, 2004-02-09 at 16:07 -0500, Geoffrey Young wrote: > > >>perlsection.conf.in would work - even though it contains no variable > >>substitution, it would keep all the conf files together and solve your issue > >> as well. > > No. if y

Re: cvs commit: modperl-2.0 Changes

2004-02-09 Thread Stas Bekman
Geoffrey Young wrote: +if (strEQ(modperl_callback_current_callback_get(), + "PerlResponseHandler")) { IIRC, the current callback is set to PerlResponseHandler for output filters as well, including the FilterInitHandler. so, we probably need to include an XXX not

Re: cvs commit: modperl-2.0 Changes

2004-02-09 Thread Geoffrey Young
> +if (strEQ(modperl_callback_current_callback_get(), > + "PerlResponseHandler")) { IIRC, the current callback is set to PerlResponseHandler for output filters as well, including the FilterInitHandler. so, we probably need to include an XXX note here that pus

Re: [mp2] moving t/conf/perlsection.conf elsewhere?

2004-02-09 Thread Stas Bekman
On Mon, 2004-02-09 at 16:07 -0500, Geoffrey Young wrote: perlsection.conf.in would work - even though it contains no variable substitution, it would keep all the conf files together and solve your issue as well. No. if you do that Apache-Test will 'Include' that file, which is not what we want. N

Re: [mp2] moving t/conf/perlsection.conf elsewhere?

2004-02-09 Thread Philippe M. Chiasson
On Mon, 2004-02-09 at 16:07 -0500, Geoffrey Young wrote: > Stas Bekman wrote: > > Philippe, > > > > Can t/conf/perlsection.conf be moved elsewhere? > > #Handle re-entrant sections > > > > $Include = "@ServerRoot@/conf/perlsection.conf"; > > > > > > the problem with .conf files is that the are

Re: cvs commit: modperl-2.0 Changes

2004-02-09 Thread Philippe M. Chiasson
On Mon, 2004-02-09 at 13:10 -0800, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > >> Perl(Input|Output)FilterHandler handlers are now always AutoLoaded, as > >> if '+' prefix was used. This must be performed to get the access to > >> filter attributes long before the filter itself is exec

Re: cvs commit: modperl-2.0 Changes

2004-02-09 Thread Stas Bekman
Philippe M. Chiasson wrote: Perl(Input|Output)FilterHandler handlers are now always AutoLoaded, as if '+' prefix was used. This must be performed to get the access to filter attributes long before the filter itself is executed. + tests [...] - # must be preloaded so the FilterConnectionHa

Re: [mp2] moving t/conf/perlsection.conf elsewhere?

2004-02-09 Thread Geoffrey Young
Stas Bekman wrote: > Philippe, > > Can t/conf/perlsection.conf be moved elsewhere? > #Handle re-entrant sections > > $Include = "@ServerRoot@/conf/perlsection.conf"; > > > the problem with .conf files is that the are usually autogenerated, and > when config fails sometimes one needs to nuke

[mp2] moving t/conf/perlsection.conf elsewhere?

2004-02-09 Thread Stas Bekman
Philippe, Can t/conf/perlsection.conf be moved elsewhere? #Handle re-entrant sections $Include = "@ServerRoot@/conf/perlsection.conf"; the problem with .conf files is that the are usually autogenerated, and when config fails sometimes one needs to nuke them manually. Usually t/conf/*.conf doe

Re: [mp2] read/write access to server/process records (+patches)

2004-02-09 Thread Geoffrey Young
Stas Bekman wrote: > I'm trying to resolve two related items in todo/release: > > The first step: provide support for read-only structure accessors, > made all perl server_rec and process_rec accessors read-only (the patch > is below). I agree with most of this, save certain attributes of the

Re: cvs commit: modperl-2.0 Changes

2004-02-09 Thread Philippe M. Chiasson
On Mon, 2004-02-09 at 18:18 +, [EMAIL PROTECTED] wrote: > stas2004/02/09 10:18:16 > > Modified:lib/ModPerl Code.pm >src/modules/perl modperl_cmd.c modperl_cmd.h >t/filter/TestFilter in_bbs_inject_header.pm in_bbs_msg.pm > in

[mp2] read/write access to server/process records (+patches)

2004-02-09 Thread Stas Bekman
I'm trying to resolve two related items in todo/release: -- some autogenerated record accessors shouldn't be get/set but only get (e.g. Apache->server->is_virtual(1) is wrong). Need to add a new flag supported by MapUtil and map files, where we can say which accessors should b

Re: anon subs in httpd.conf

2004-02-09 Thread Stas Bekman
Geoffrey Young wrote: hi all... I noticed today that this now works PerlLogHandler 'sub { warn shift->as_string }' (a favorite debugging line of mine), much to my surprise, since I know back in 1.99_07 (before I implemented as_string) I tried it and it didn't work - it threw the 'anonymous h

[mp2 patch] ModPerl/EazyLife.pm (was Re: [mp2] killing the ghost Apache:: usage?)

2004-02-09 Thread Stas Bekman
Stas Bekman wrote: Perrin Harkins wrote: On Tue, 2004-01-20 at 16:17, Stas Bekman wrote: I now more or less have an idea on how to solve the code usage problem. Great! My idea is replace UNIVERSAL::AUTOLOAD with AUTOLOAD for each class that contains objects, so when the method is called on t

Re: BUG REPORT: mod_perl2 installation bug on failed apr-ext/uuid.t test

2004-02-09 Thread Geoffrey Young
Jeff Beer wrote: > apr-ext/uuid.t 255 65280 36 200.00% 1-3 that's odd - 6 of 3 (200%) tests failed? I've seen that kind of thing before where there are problems with Test.pm and the order in which the tests show up... > [EMAIL PROTECTED] mod_perl-1.99_12 ]# cat t/REPORT please run