here's another pass that incorporates the suggestions thus far. comments on
the global foo appreciated. the tests I posted before are still valid at
this point.
--Geoff
Index: lib/ModPerl/Code.pm
===
RCS file: /home/cvspublic/modper
On Sat, 2004-02-28 at 14:46, Stas Bekman wrote:
> Philippe M. Chiasson wrote:
> > Improvements to my previous patch:
> >
> > - Small cleanups as suggested.
> > - Documented
>
> [...]
> > Index: lib/Apache/PerlSections/Dump.pm
> [...]
> > +#Process all saved packages
> > +sub package { return
Philippe M. Chiasson wrote:
Improvements to my previous patch:
- Small cleanups as suggested.
- Documented
[...]
Index: lib/Apache/PerlSections/Dump.pm
[...]
+#Process all saved packages
+sub package { return shift->saved }
+
+#We don't want to save anything
+sub save{ return }
+
+#We
Improvements to my previous patch:
- Small cleanups as suggested.
- Documented
Index: Changes
===
RCS file: /home/cvs/modperl-2.0/Changes,v
retrieving revision 1.334
diff -u -I$Id -r1.334 Changes
--- Changes 26 Feb 2004 23:29:06
Philippe M. Chiasson wrote:
Actually, no, it's quite the opposite. Those empty functions are there
to disable these actions in the parent class. A::P::Dump isa
A::PerlSections and really just overrides a few things, like
dump_item(), but in the parent class, for instance, post_config() is the
sub
On Sat, 2004-02-28 at 14:14, Stas Bekman wrote:
> Philippe M. Chiasson wrote:
> > Finally got around implementing Apache::PerlSections->(dump|store);
> >
> > Comments ?
> >
> > Index: lib/Apache/PerlSections.pm
> > ===
> > RCS file:
Philippe M. Chiasson wrote:
On Fri, 2004-02-27 at 20:06, Geoffrey Young wrote:
Philippe M. Chiasson wrote:
On Fri, 2004-02-27 at 19:38, Geoffrey Young wrote:
Philippe M. Chiasson wrote:
Finally got around implementing Apache::PerlSections->(dump|store);
Comments ?
freeze/thaw?
What do you
Philippe M. Chiasson wrote:
Finally got around implementing Apache::PerlSections->(dump|store);
Comments ?
Index: lib/Apache/PerlSections.pm
===
RCS file: /home/cvs/modperl-2.0/lib/Apache/PerlSections.pm,v
retrieving revision 1.2
dif
On Fri, 2004-02-27 at 20:06, Geoffrey Young wrote:
> Philippe M. Chiasson wrote:
> > On Fri, 2004-02-27 at 19:38, Geoffrey Young wrote:
> >
> >>Philippe M. Chiasson wrote:
> >>
> >>>Finally got around implementing Apache::PerlSections->(dump|store);
> >>>
> >>>Comments ?
> >>
> >>freeze/thaw?
> >
