On Mon, 2004-03-01 at 12:36 -0800, Stas Bekman wrote:
> Geoffrey Young wrote:
> >
> > Stas Bekman wrote:
> >
> >>I've looked at the httpd source code, ptemp is destroyed at the end of
> >>the post_config phase. So we should use it for any temporary things that
> >>don't need to live through the c
Geoffrey Young wrote:
Stas Bekman wrote:
I've looked at the httpd source code, ptemp is destroyed at the end of
the post_config phase. So we should use it for any temporary things that
don't need to live through the config.
So hook-config is the perfect case for ptemp.
that's fine, but how do yo
> I've now got the same problem as you, Randy -- it runs one set of tests
> OK (all successful), but then hangs trying to start the server the
> second time.
consistency is good :)
I'm still unclear as to whether this is a fault of the new hook-ordering
implementation, or a symptom of the way
Stas Bekman wrote:
> I've looked at the httpd source code, ptemp is destroyed at the end of
> the post_config phase. So we should use it for any temporary things that
> don't need to live through the config.
>
> So hook-config is the perfect case for ptemp.
that's fine, but how do you get to it
I've looked at the httpd source code, ptemp is destroyed at the end of the
post_config phase. So we should use it for any temporary things that don't
need to live through the config.
So hook-config is the perfect case for ptemp. We need to review other places
where we should use ptemp instead.
Geoffrey Young wrote:
but you need to pass pool... so may be not... just another idea to make
mod_perl.c less cluttered.
passing the pool isn't that big a deal, or I could just use
modperl_global_get_pconf(), in which case I'll also need to use pconf for
the logic in modperl_cmd then (instead of
> Actually, you don't even need modperl_apache_init_hook_order(), just
> move that init code into: modperl_apache_get_hook_order();
>
> void modperl_apache_get_hook_order(apr_pool_t *p) {
> if (!hook_order) {
> hook_order = apr_table_make(p, 0);
> }
> return hook_order;
> }
I
Geoffrey Young wrote:
It should be:
modperl_apache_init_hooks(p);
void modperl_apache_init_hook_order(apr_pool_t p) {
hook_order = apr_table_make(p, 0);
}
ok, I'll do that. I was trying to solve a very strange problem that I
couldn't figure out (but would probably obvious to someone e
> It should be:
>
> modperl_apache_init_hooks(p);
>
> void modperl_apache_init_hook_order(apr_pool_t p) {
> hook_order = apr_table_make(p, 0);
> }
ok, I'll do that. I was trying to solve a very strange problem that I
couldn't figure out (but would probably obvious to someone else, na
Randy Kobes wrote:
>On Mon, 1 Mar 2004, Steve Hay wrote:
>
>
>>What do I do with the hook_order_test-mp2.tar.gz tests? Pardon my
>>ignorance, but I have no idea where to put these files or what to do
>>with them.
>>
>>
>
>If I recall, you have the Win32 apxs installed? If so, all
>you need
Randy Kobes wrote:
ThreadsPerChild 50
MaxRequestsPerChild 0
The standard mp2 testsuite now passes all tests successful.
I forgot to mention - I've also found lately that raising
this limit is necessary.
Any idea why? 50 threads is not enough to run the tests, when with prefork
onl
Geoffrey Young wrote:
Index: src/modules/perl/mod_perl.c
===
RCS file: /home/cvs/modperl-2.0/src/modules/perl/mod_perl.c,v
retrieving revision 1.210
diff -u -r1.210 mod_perl.c
--- src/modules/perl/mod_perl.c 1 Mar 2004 04:24:00 -
On Mon, 1 Mar 2004, Steve Hay wrote:
> Geoffrey Young wrote:
[ ... ]
> >ok, I'll hold off on committing then. attached is the final patch I would
> >have put in this evening, fwiw.
> >
> >as I mentioned, I'd be interested to know if the test suite I had sent runs
> >against current pristine CVS -
Geoffrey Young wrote:
>>>or you could just comment out each
>>>different startup in TEST.PL (or just TEST if you don't feel like running
>>>Makefile.PL each time) and run each one at a time.
>>>
>>>
>>I just did that - only two of the tests sequences run
>>individually - one where -defines i
14 matches
Mail list logo
