Re: cvs commit: modperl-2.0 Changes

2004-03-02 Thread Stas Bekman
I hope this code will work correctly on win32 and other non-unix platforms. I have no clue why Apache folks have mixed CR (defined in httpd.h) and '\n' in their code, but I guess if it's there, it's safe to use it. basically it does: my($headers, $body) = split $buffer, /\n\r?\n/; +/*

compiling on win32

2004-03-02 Thread Geoffrey Young
hi all (especially randy and steve) ok, so I'm trying to compile things on win32 (win2k with VC++ 5.0). I've followed the mp2 instructions, which pointed me toward compiling Apache 2.0 from sources. I'm using the official 2.0.48 sources. so, never having using VC++ before (don't ask me why I ha

Re: dynamic request hook ordering (take 2)

2004-03-02 Thread Geoffrey Young
>>ok. I don't suppose that sleeping between startups makes a difference? >> > > Sleeping between what? One test /on its own/ doesn't work! yes, I realized after I sent it that you already found the problem has nothing to do with stopping or starting. oops :) >>the only thing I could suggest

Re: dynamic request hook ordering (take 2)

2004-03-02 Thread Steve Hay
Geoffrey Young wrote: >Geoffrey Young wrote: > > >>stas at one point >>suggested nulling the table when I'm done with it, which might also be an >>idea >> >> > >to that end, here is yet another patch to try. > Nope :( Still the same results for me I'm afraid. - Steve ---

Re: dynamic request hook ordering (take 2)

2004-03-02 Thread Steve Hay
Geoffrey Young wrote: >>The ReallyFirst test runs OK on its own, though. >> >> > >it seems I forgot to add a -DReallyFirst, so this is running the default as >well. > Doh! Have you added it now? I've built & installed this new patch and I still find that -DReallyFirst works fine... > > >

Re: dynamic request hook ordering (take 2)

2004-03-02 Thread Geoffrey Young
>>I'm still unclear as to whether this is a fault of the new hook-ordering >>implementation, or a symptom of the way I chose to setup the tests. does it >>behave the same way against pristine mod_perl CVS? >> > > How can I try that?! If I run it against pristine mp2 CVS then it > complains "In

Re: dynamic request hook ordering (take 2)

2004-03-02 Thread Steve Hay
Geoffrey Young wrote: >>I've now got the same problem as you, Randy -- it runs one set of tests >>OK (all successful), but then hangs trying to start the server the >>second time. >> >> > >consistency is good :) > >I'm still unclear as to whether this is a fault of the new hook-ordering >imp