Rafael Garcia-Suarez wrote:
> > The preprocessor converts line 564 into
> >
> > (void) (*Perl_Gsigfpe_saved_ptr(((void *)0))) = signal(8,
> > ((__sighandler_t) 1)); ;
>
> Not a valid C line.
>
> Note that PERL_SYS_INIT3 can expand to multiple statements; IMHO you
> shouldn't cast it to void
Torsten Foertsch wrote:
> On Tuesday 06 June 2006 11:46, Philip M. Gollucci wrote:
> > Torsten Foertsch wrote:
> > > Further on, in line 564 it complains about an illegal typecast. This
> > > Linux behaves in this regard obviously like Windows.
> > >
> > > 561 #ifdef WIN32
> > > 562 PER
That said, this patch could help :
Actually, on some systems and with some compilers, PERL_SYS_INIT3 could
even begin with if(1).
So, don't cast PERL_SYS_INIT3 to void.
If we know what prompted the addition of this (void) cast here, we could
fix the origin of the warning upstream... (if not ye
On Tue, 6 Jun 2006, Steve Hay wrote:
Steve Hay wrote:
Randy Kobes wrote:
Thanks very much for the explanation, Steve - that makes
sense. So as was mentioned earlier, this problem probably
won't be encountered by the majority of Win32 users,
who will be unpacking a CPAN distribution. It is
anno
Philip M. Gollucci wrote:
> Torsten Foertsch wrote:
>
>> What is the common understanding on this point by now?
>> -retval = *hv_store(*pnotes, k, len, SvREFCNT_inc(val), 0);
>> +retval = *hv_store(*pnotes, k, len, newSVsv(val), 0);
>
> Pushes the cobwebs aside.
> I ag
On Tuesday 06 June 2006 12:38, Philip M. Gollucci wrote:
> Torsten Foertsch wrote:
> > What is the common understanding on this point by now?
> > - retval = *hv_store(*pnotes, k, len, SvREFCNT_inc(val), 0);
> > + retval = *hv_store(*pnotes, k, len, newSVsv(val), 0);
>
> Pushes
Steve Hay wrote:
Randy Kobes wrote:
Thanks very much for the explanation, Steve - that makes
sense. So as was mentioned earlier, this problem probably
won't be encountered by the majority of Win32 users,
who will be unpacking a CPAN distribution. It is
annoying for svn users though who may encou
On Tuesday 06 June 2006 11:46, Philip M. Gollucci wrote:
> Torsten Foertsch wrote:
> > Further on, in line 564 it complains about an illegal typecast. This
> > Linux behaves in this regard obviously like Windows.
> >
> > 561 #ifdef WIN32
> > 562 PERL_SYS_INIT3(&argc, &argv, &env);
> >
Torsten Foertsch wrote:
What is the common understanding on this point by now?
-retval = *hv_store(*pnotes, k, len, SvREFCNT_inc(val), 0);
+retval = *hv_store(*pnotes, k, len, newSVsv(val), 0);
Pushes the cobwebs aside.
I agree that the change you propose will accompl
Hi,
some time ago there was an argument about the "right" behavior of pnotes, see
http://www.gossamer-threads.com/lists/modperl/dev/87819.
The question was whether $r->pnotes(key=>value) should do exactly the same as
$r->pnotes->{key}=value or for some historical reason not.
The problem is tha
[CC'ed p5p]
Torsten Foertsch wrote:
Further on, in line 564 it complains about an illegal typecast. This Linux
behaves in this regard obviously like Windows.
561 #ifdef WIN32
562 PERL_SYS_INIT3(&argc, &argv, &env);
563 #else
564 (void)PERL_SYS_INIT3(&argc, &argv, &env);
Torsten Foertsch wrote:
While testing one test then failed in t/apache/content_length_header.t:
# testing : HEAD /TestApache__content_length_header?set_content_length C-L
header
# expected: 25
# received: undef
not ok 17
# Failed test 17 in t/apache/content_length_header.t at line 71 fail #2
Torsten Foertsch wrote:
Hi,
I got a warning on line 488 in mod_perl.c about an unused variable
'base_scfg':
Committed 412039
http://svn.apache.org/viewvc?rev=412039&view=rev
More to follow.
--
Philip M. Gollucci ([EMAIL
Hi,
I got a warning on line 488 in mod_perl.c about an unused variable
'base_scfg':
485 #ifdef USE_ITHREADS
486 static void modperl_init_clones(server_rec *s, apr_pool_t *p)
487 {
488 modperl_config_srv_t *base_scfg = modperl_config_srv_get(s);
489 #ifdef MP_TRACE
490
14 matches
Mail list logo
