lets not forget we are a CTR PMC

2010-04-15 Thread Philip M. Gollucci
Thats Commit Then Review. Its a VC we can always revert things. The RTC (Review Then Committ) suggestion is only for new committers while they get acclimated. Unless its some massive architectural change which will probably be prose explanation anyway. -- ---

Re: [patch] https://rt.cpan.org/Ticket/Display.html?id=32993

2010-04-15 Thread Fred Moyer
On Thu, Apr 15, 2010 at 7:25 PM, Philip M. Gollucci wrote: > I forget where off the top of my head, but A-T has a function to search > $PATH for binaries. Apache::TestConfig::which('binary'); And aptly named, thanks for the spot on my previous hack. I'm not sure how to test this specifically, s

Re: [patch] https://rt.cpan.org/Ticket/Display.html?id=32993

2010-04-15 Thread Philip M. Gollucci
On 4/15/2010 10:08 PM, Fred Moyer wrote: RT: https://rt.cpan.org/Ticket/Display.html?id=32993 Please take a look at this revised patch here and give a +1, 0, or -1. Thanks! Index: lib/Apache/TestHarnessPHP.pm === --- lib/Apache/

[patch] https://rt.cpan.org/Ticket/Display.html?id=32993

2010-04-15 Thread Fred Moyer
RT: https://rt.cpan.org/Ticket/Display.html?id=32993 Please take a look at this revised patch here and give a +1, 0, or -1. Thanks! Index: lib/Apache/TestHarnessPHP.pm === --- lib/Apache/TestHarnessPHP.pm(revision 934663)

RT 32992

2010-04-15 Thread Fred Moyer
https://rt.cpan.org/Ticket/Display.html?id=32992 Taking a poll again of who supports this issue resolution. Given that the previous stable version of perl (5.10.1) has version.pm bundled (current version is 5.12.0), I think this is safe move. 5.8.8 does not have version.pm bundled, but it is eas

[ANNOUNCE] Apache-Test 1.32

2010-04-15 Thread Fred Moyer
MD5sum - e9249af12e427d58802f1715116aeba7 Coming to a CPAN mirror near you. Fix issue with recent feature where lack of libapreq resulted in test failure. [Philippe M. Chiasson] Added t_{start,read,finish}_file_watch to Apache::TestUtil [Torsten Foertsch] -- Forwarded message -