Re: [RELEASE CANDIDATE]: mod_perl-2.0.6 RC1

2012-02-14 Thread Fred Moyer
I've pushed RC2 which contains Steve and Niko's fixes. +1 on 2.2.21/5.14.1 and Lion 10.6. http://people.apache.org/~phred/mod_perl-2.0.6-rc2.tar.gz MD5 (mod_perl-2.0.6-rc2.tar.gz) = 3bc64d1ab66c29361e8a6a0ee044e667 2012/2/14 Torsten Förtsch : > On Tuesday, 14 February 2012 09:15:25 Fred Moyer

Re: [RELEASE CANDIDATE]: mod_perl-2.0.6 RC1

2012-02-14 Thread Torsten Förtsch
On Tuesday, 14 February 2012 09:15:25 Fred Moyer wrote: > > http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=50;filename=0001-Fix-a- > > reference-counting-bug-uncovered-by-Perl-5.13..patch;att=2;bug=650675 > > > > http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=50;filename=0002-Fix-an > > other-

Re: [RELEASE CANDIDATE]: mod_perl-2.0.6 RC1

2012-02-14 Thread Fred Moyer
On Tuesday, February 14, 2012 at 8:53 AM, Torsten Förtsch wrote: > Fred, now that the OOM issue has been resolved is there anything left for > 2.0.6 other than the Niko Tyni issue? It seems that I have missed a few > messages in that regard. Are the following 2 patches all there is to it? >

Re: [RELEASE CANDIDATE]: mod_perl-2.0.6 RC1

2012-02-14 Thread Torsten Förtsch
On Tuesday, 14 February 2012 14:15:25 Steve Hay wrote: > I've committed the ModPerl::MM fix, renaming $b to $build Thanks. It passes all tests here with linux, perl 5.12.3, worker and prefork. > And I definitely agree that any code commented "should not happen" ought to > assert when it does happ

RE: [RELEASE CANDIDATE]: mod_perl-2.0.6 RC1

2012-02-14 Thread Steve Hay
Argh! Just found the cause of the out of memory error: When I had httpd.exe crashing previously (due to thread context problems revealed by the LimitExcept change) I enabled the page heap for httpd.exe to trap any writes past allocated memory at the point of occurrence, and I'd completely forgot

RE: [RELEASE CANDIDATE]: mod_perl-2.0.6 RC1

2012-02-14 Thread Steve Hay
[Apologies for all the top-posting replies, btw. Blame Outlook! I have a macro somewhere to fix it, but haven't installed it yet on my new machine...] I've committed the ModPerl::MM fix, renaming $b to $build, and generally borrowing the style of ModPerl::BuildMM (although it's all rather ugly a

Re: [RELEASE CANDIDATE]: mod_perl-2.0.6 RC1

2012-02-14 Thread Torsten Förtsch
On Tuesday, 14 February 2012 09:58:51 Steve Hay wrote: > The patch below fixes the problems with MP_LIBNAME (and cwd) not being set > correctly when building Apache::Reload and Apache::SizeLimit. > > The problem was that the file-level $b variable was created only once when > ModPerl::MM was first

RE: [RELEASE CANDIDATE]: mod_perl-2.0.6 RC1

2012-02-14 Thread Steve Hay
The patch below fixes the problems with MP_LIBNAME (and cwd) not being set correctly when building Apache::Reload and Apache::SizeLimit. The problem was that the file-level $b variable was created only once when ModPerl::MM was first loaded, but that happened before Apache2::BuildConfig.pm was