Re: svn commit: r1299669 - in /perl/modperl/trunk: Changes src/modules/perl/modperl_error.c xs/APR/Pool/APR__Pool.h xs/Apache2/ServerUtil/Apache2__ServerUtil.h

2012-03-12 Thread Fred Moyer
I'm not clear on the end user implications of this - how will the error be presented now? On Mon, Mar 12, 2012 at 6:27 AM, wrote: > Author: torsten > Date: Mon Mar 12 13:27:30 2012 > New Revision: 1299669 > > URL: http://svn.apache.org/viewvc?rev=1299669&view=rev > Log: > Do not stringify $@ upo

Re: Bug#661540: libapache2-mod-perl2: FTBFS with hardening flags enabled: -Werror=format-security

2012-03-12 Thread Niko Tyni
On Mon, Mar 12, 2012 at 02:58:05PM +0100, Torsten Förtsch wrote: > On Friday, 09 March 2012 22:50:33 Niko Tyni wrote: > > The two usage warnings use constant strings so > > they seem safe, > > They are safe since the "usage" variable is constant and does not contain any > %-sequences. I do not se

Re: Bug#661540: libapache2-mod-perl2: FTBFS with hardening flags enabled: -Werror=format-security

2012-03-12 Thread Torsten Förtsch
On Friday, 09 March 2012 22:50:33 Niko Tyni wrote: > The two usage warnings use constant strings so > they seem safe, They are safe since the "usage" variable is constant and does not contain any %-sequences. I do not see the need to fix anything here. What do I miss? > but I'm afraid I can't te

Re: Bug#661540: libapache2-mod-perl2: FTBFS with hardening flags enabled: -Werror=format-security

2012-03-12 Thread Torsten Förtsch
On Friday, 09 March 2012 22:50:33 Niko Tyni wrote: > -Perl_croak(aTHX_ SvPV_nolen(ERRSV)); > +Perl_croak(aTHX_ "%s", SvPV_nolen(ERRSV)); Thanks! But isn't the right way to rethrow/propagate an exception (with respect to exception objects) this? Perl_croak(aTHX_ Nullch); Unles