Re: [RELEASE CANDIDATE]: mod_perl-2.0.5 RC5

2012-04-20 Thread Adam Prime
Committed revision 1328477. Adam On 12-04-20 11:15 AM, Fred Moyer wrote: +1 for this fix. Adam, if you want to apply it, I'll roll RC6. On Fri, Apr 20, 2012 at 8:13 AM, Adam Prime wrote: #if defined(__GNUC__)&&!defined(PERL_GCC_BRACE_GROUPS_FORBIDDEN) # define MUTABLE_PTR(p) ({ void

Re: [RELEASE CANDIDATE]: mod_perl-2.0.5 RC5

2012-04-20 Thread Fred Moyer
+1 for this fix. Adam, if you want to apply it, I'll roll RC6. On Fri, Apr 20, 2012 at 8:13 AM, Adam Prime wrote: >> #if defined(__GNUC__)&&  !defined(PERL_GCC_BRACE_GROUPS_FORBIDDEN) > >> #  define MUTABLE_PTR(p) ({ void *_p = (p); _p; }) >> #else >> #  define MUTABLE_PTR(p) ((void *) (p)) >> #e

Re: [RELEASE CANDIDATE]: mod_perl-2.0.5 RC5

2012-04-20 Thread Adam Prime
> #if defined(__GNUC__)&& !defined(PERL_GCC_BRACE_GROUPS_FORBIDDEN) > # define MUTABLE_PTR(p) ({ void *_p = (p); _p; }) > #else > # define MUTABLE_PTR(p) ((void *) (p)) > #endif > > So the solution for the problem is simple: > > # ifdef MUTABLE_SV >SV *sv=MUTABLE_SV(...); > # else >SV *

Re: [RELEASE CANDIDATE]: mod_perl-2.0.5 RC5

2012-04-20 Thread Torsten Förtsch
On Thursday, 19 April 2012 18:45:59 Fred Moyer wrote: > > Apparently MUTABLE_CV doesn't exist under 5.8.8 > > Verified. Thoughts? +1 to ship as is. 5.8.8 isn't being shipped with > any new Linux or other OS distributions as far as I know. I think the central question is how many perl versions bac