Re: [mp2] cleaning up Apache::Log

2004-08-21 Thread Stas Bekman
Vivek Khera wrote: On Aug 19, 2004, at 3:03 AM, Stas Bekman wrote: And I'm still trying to figure out whether it's possible to make 'a plain warn()' log into the vhost log (die already logs into the vhost log). I haven't yet checked how it worked in mp1, I think it never did. A plain warn() in m

Re: [mp2] cleaning up Apache::Log

2004-08-19 Thread Geoffrey Young
> ($r|$s)->log->(warn|crit|...) are all there. They are fine (well, not > exactly all of them, but I'm working on that). cool. then I'm fine with your suggestion. --Geoff - To unsubscribe, e-mail: [EMAIL PROTECTED] For additi

Re: [mp2] cleaning up Apache::Log

2004-08-19 Thread Stas Bekman
Vivek Khera wrote: On Aug 19, 2004, at 3:03 AM, Stas Bekman wrote: And I'm still trying to figure out whether it's possible to make 'a plain warn()' log into the vhost log (die already logs into the vhost log). I haven't yet checked how it worked in mp1, I think it never did. A plain warn() in m

Re: [mp2] cleaning up Apache::Log

2004-08-19 Thread Stas Bekman
Geoffrey Young wrote: I think this should be reduced to: * $r->log_error * $r->warn * $s->log_error * $s->warn don't forget about $r->log->warn(), which is slightly different than $r->warn() in mp1, as well as $r->log->info(), etc which are frequently used in mp1. I haven't checke

Re: [mp2] cleaning up Apache::Log

2004-08-19 Thread Geoffrey Young
> I think this should be reduced to: > > * $r->log_error > * $r->warn > * $s->log_error > * $s->warn don't forget about $r->log->warn(), which is slightly different than $r->warn() in mp1, as well as $r->log->info(), etc which are frequently used in mp1. I haven't checked if

Re: [mp2] cleaning up Apache::Log

2004-08-19 Thread Vivek Khera
On Aug 19, 2004, at 3:03 AM, Stas Bekman wrote: And I'm still trying to figure out whether it's possible to make 'a plain warn()' log into the vhost log (die already logs into the vhost log). I haven't yet checked how it worked in mp1, I think it never did. A plain warn() in mp1 does end up in t

[mp2] cleaning up Apache::Log

2004-08-19 Thread Stas Bekman
I'm working on finishing Apache::Log, besides several issues I've a test for (like $s->log_error logging into the main server error log instead of vhost), I want to cut the amount of the ways one can log. Among others we have: * Apache::warn * Apache->warn * Apache::Server->log_e