Re: [patch]avoid closing fd 0/1

2010-04-07 Thread Torsten Förtsch
On Sunday 04 April 2010 18:43:29 Torsten Förtsch wrote: > This is another idea to solve the problem. We used to save and restore the > file handle. Why not simply localize it? > [...] > Opinions? > > How do I build a modperl that uses tied IO? > This version compiles cleanly and passes all test

Re: [patch]avoid closing fd 0/1

2010-04-04 Thread Torsten Förtsch
On Wednesday 31 March 2010 16:43:04 Torsten Förtsch wrote: > This one is much simpler. > This is another idea to solve the problem. We used to save and restore the file handle. Why not simply localize it? The caller of the override/restore functions already creates the opening and closing brace

Re: [patch]avoid closing fd 0/1

2010-04-04 Thread Torsten Förtsch
On Friday 02 April 2010 22:56:48 Philippe M. Chiasson wrote: > I would very much > appreciate seeing a test case for this known issue/bug. > Here are 2 test cases. The 2nd one is a bit stricter in that it requires a file handle attribute ($.) to survive, not the file descriptor: Index: t/respons

Re: [patch]avoid closing fd 0/1

2010-04-02 Thread Philippe M. Chiasson
On 10-03-31 10:59 , Torsten Förtsch wrote: > On Wednesday 31 March 2010 16:43:04 Torsten Förtsch wrote: >> I believe the IoFLUSH_off in the override function can be omitted since >> this is standard for a new handle. >> > This appears to be true. This is now the final version of the patch. Are > t

Re: [patch]avoid closing fd 0/1

2010-04-02 Thread Philip M. Gollucci
God speed messing with PerlIO stuff. On 04/01/10 14:34, Torsten Förtsch wrote: On Wednesday 31 March 2010 17:55:47 Fred Moyer wrote: Can you repost the latest patch inline so that interested parties can add comments and understand what is going on in there? I know that only a few people under

Re: [patch]avoid closing fd 0/1

2010-04-01 Thread Torsten Förtsch
On Wednesday 31 March 2010 17:55:47 Fred Moyer wrote: > Can you repost the latest patch inline so that interested parties can > add comments and understand what is going on in there? I know that > only a few people understand the innards of mod_perl with XS magic, > but just getting it out there w

Re: [patch]avoid closing fd 0/1

2010-03-31 Thread Fred Moyer
2010/3/31 Torsten Förtsch : > On Wednesday 31 March 2010 16:43:04 Torsten Förtsch wrote: >> I believe the IoFLUSH_off in the override function can be omitted since >> this is standard for a new handle. >> > This appears to be true. This is now the final version of the patch. Are there > any objecti

Re: [patch]avoid closing fd 0/1

2010-03-31 Thread Torsten Förtsch
On Wednesday 31 March 2010 16:43:04 Torsten Förtsch wrote: > I believe the IoFLUSH_off in the override function can be omitted since > this is standard for a new handle. > This appears to be true. This is now the final version of the patch. Are there any objections against applying it to trunk?

Re: [patch]avoid closing fd 0/1

2010-03-31 Thread Torsten Förtsch
On Tuesday 30 March 2010 19:10:36 Torsten Förtsch wrote: > Previously the code did something similar to > > open SAVEFH, '<&STDIN'; > close STDIN; > ... > open STDIN, '<&SAVEFH'; > > The idea is to change that into > > open SAVEFH, '<&='.fileno(STDIN); > close STDIN; > ... > open

Re: [patch]avoid closing fd 0/1

2010-03-30 Thread Torsten Förtsch
On Tuesday 30 March 2010 20:08:00 Fred Moyer wrote: > Torsten can you post a breakdown of each part in the patch so those of > us who can't grok all of it (I'm one of them!) can get a handle (no > pun intended) on what each part does? > Best I think if you look at the patch result. Previously ther

Re: [patch]avoid closing fd 0/1

2010-03-30 Thread Fred Moyer
Torsten can you post a breakdown of each part in the patch so those of us who can't grok all of it (I'm one of them!) can get a handle (no pun intended) on what each part does? 2010/3/30 Fred Moyer : > 2010/3/30 Torsten Förtsch : >> Hi, >> >> the patch below is a raw fix for the "mod_perl closes a

Re: [patch]avoid closing fd 0/1

2010-03-30 Thread Fred Moyer
2010/3/30 Torsten Förtsch : > Hi, > > the patch below is a raw fix for the "mod_perl closes apache's stdin and/or > stdout"-bug, see also > >  http://www.gossamer-threads.com/lists/modperl/modperl/94921 Posting a copy of the patch inline for the archives. Thanks for putting this together Torsten.

[patch]avoid closing fd 0/1

2010-03-30 Thread Torsten Förtsch
Hi, the patch below is a raw fix for the "mod_perl closes apache's stdin and/or stdout"-bug, see also http://www.gossamer-threads.com/lists/modperl/modperl/94921 Previously the code did something similar to open SAVEFH, '<&STDIN'; close STDIN; ... open STDIN, '<&SAVEFH'; The idea is