Re: compiling trunk on Suse Linux 10.1

2006-06-07 Thread Rafael Garcia-Suarez
On 06/06/06, Philip M. Gollucci <[EMAIL PROTECTED]> wrote: Hi, I added it recently because as a MP maintainer, I use MP_MAINTAINER=1 which adds -Werror to the CFLAGS among other things. That being done, you get this warning in gcc 4.{0,1,2}.x "value computed not used" http://svn.apache.org/vie

Re: compiling trunk on Suse Linux 10.1

2006-06-06 Thread Rafael Garcia-Suarez
Rafael Garcia-Suarez wrote: > > The preprocessor converts line 564 into > > > > (void) (*Perl_Gsigfpe_saved_ptr(((void *)0))) = signal(8, > > ((__sighandler_t) 1)); ; > > Not a valid C line. > > Note that PERL_SYS_INIT3 can expand to multiple statements; IMHO you > shouldn't cast it to void

Re: compiling trunk on Suse Linux 10.1

2006-06-06 Thread Rafael Garcia-Suarez
Torsten Foertsch wrote: > On Tuesday 06 June 2006 11:46, Philip M. Gollucci wrote: > > Torsten Foertsch wrote: > > > Further on, in line 564 it complains about an illegal typecast. This > > > Linux behaves in this regard obviously like Windows. > > > > > >    561  #ifdef WIN32 > > >    562      PER

Re: compiling trunk on Suse Linux 10.1

2006-06-06 Thread Philip M. Gollucci
That said, this patch could help : Actually, on some systems and with some compilers, PERL_SYS_INIT3 could even begin with if(1). So, don't cast PERL_SYS_INIT3 to void. If we know what prompted the addition of this (void) cast here, we could fix the origin of the warning upstream... (if not ye

Re: compiling trunk on Suse Linux 10.1

2006-06-06 Thread Torsten Foertsch
On Tuesday 06 June 2006 11:46, Philip M. Gollucci wrote: > Torsten Foertsch wrote: > > Further on, in line 564 it complains about an illegal typecast. This > > Linux behaves in this regard obviously like Windows. > > > >    561  #ifdef WIN32 > >    562      PERL_SYS_INIT3(&argc, &argv, &env); > >  

Re: compiling trunk on Suse Linux 10.1

2006-06-06 Thread Philip M. Gollucci
[CC'ed p5p] Torsten Foertsch wrote: Further on, in line 564 it complains about an illegal typecast. This Linux behaves in this regard obviously like Windows. 561 #ifdef WIN32 562 PERL_SYS_INIT3(&argc, &argv, &env); 563 #else 564 (void)PERL_SYS_INIT3(&argc, &argv, &env);

Re: compiling trunk on Suse Linux 10.1

2006-06-06 Thread Philip M. Gollucci
Torsten Foertsch wrote: While testing one test then failed in t/apache/content_length_header.t: # testing : HEAD /TestApache__content_length_header?set_content_length C-L header # expected: 25 # received: undef not ok 17 # Failed test 17 in t/apache/content_length_header.t at line 71 fail #2

Re: compiling trunk on Suse Linux 10.1

2006-06-06 Thread Philip M. Gollucci
Torsten Foertsch wrote: Hi, I got a warning on line 488 in mod_perl.c about an unused variable 'base_scfg': Committed 412039 http://svn.apache.org/viewvc?rev=412039&view=rev More to follow. -- Philip M. Gollucci ([EMAIL

compiling trunk on Suse Linux 10.1

2006-06-06 Thread Torsten Foertsch
Hi, I got a warning on line 488 in mod_perl.c about an unused variable 'base_scfg': 485 #ifdef USE_ITHREADS 486 static void modperl_init_clones(server_rec *s, apr_pool_t *p) 487 { 488 modperl_config_srv_t *base_scfg = modperl_config_srv_get(s); 489 #ifdef MP_TRACE 490