Re: simplify mod_perl.c a bit

2010-04-04 Thread Randy Kobes
On 2010-04-03, at 11:32 PM, Jan Dubois wrote: > On Sat, 03 Apr 2010, Randy Kobes wrote: >> On 2010-04-03, at 8:39 PM, Philip M. Gollucci wrote: >> >>> What ANSI C std is that? >>> >>> perl core code and fbsd code do this all over the place. They are >>> supposedly C-99. >> >>> On 4/2/2010 4:4

Re: simplify mod_perl.c a bit

2010-04-04 Thread Torsten Förtsch
On Friday 02 April 2010 22:40:43 Philippe M. Chiasson wrote: > In ANSI C you can't define variables in blocks, like > > int foo(void) { > int a = 2; > some code > { > int b = 3; > more code > } > Although I am sure that ANSI C does allow for that I committed your version. K&R C di

RE: simplify mod_perl.c a bit

2010-04-03 Thread Jan Dubois
On Sat, 03 Apr 2010, Randy Kobes wrote: > On 2010-04-03, at 8:39 PM, Philip M. Gollucci wrote: > > > What ANSI C std is that? > > > > perl core code and fbsd code do this all over the place. They are > > supposedly C-99. > > > On 4/2/2010 4:40 PM, Philippe M. Chiasson wrote: > >> > >> In ANSI C

Re: simplify mod_perl.c a bit

2010-04-03 Thread Randy Kobes
On 2010-04-03, at 8:39 PM, Philip M. Gollucci wrote: > What ANSI C std is that? > > perl core code and fbsd code do this all over the place. They are > supposedly C-99. > On 4/2/2010 4:40 PM, Philippe M. Chiasson wrote: >> >> In ANSI C you can't define variables in blocks, like >> >> int foo(

Re: simplify mod_perl.c a bit

2010-04-03 Thread Philip M. Gollucci
What ANSI C std is that? perl core code and fbsd code do this all over the place. They are supposedly C-99. On 4/2/2010 4:40 PM, Philippe M. Chiasson wrote: > On 10-03-31 11:07 , Torsten Förtsch wrote: >> Hi, >> >> the patch below simplifies mod_perl.c a bit. >> >> Instead of >> >> modperl_re

Re: simplify mod_perl.c a bit

2010-04-02 Thread Philippe M. Chiasson
On 10-03-31 11:07 , Torsten Förtsch wrote: > Hi, > > the patch below simplifies mod_perl.c a bit. > > Instead of > > modperl_response_handler_run(r, finish) { > do something > if( finish ) { > modperl_response_finish() > } > } > > and calling that function in one place as > > modperl

Re: simplify mod_perl.c a bit

2010-04-02 Thread Fred Moyer
+1 On Fri, Apr 2, 2010 at 11:22 AM, Randy Kobes wrote: > +1. > > -- > best regards, > Randy > > On 2010-04-02, at 1:03 PM, Philip M. Gollucci wrote: > >> +1 >> >> On 03/31/10 15:07, Torsten Förtsch wrote: >>> Hi, >>> >>> the patch below simplifies mod_perl.c a bit. >>> >>> Instead of >>> >>> modp

Re: simplify mod_perl.c a bit

2010-04-02 Thread Randy Kobes
+1. -- best regards, Randy On 2010-04-02, at 1:03 PM, Philip M. Gollucci wrote: > +1 > > On 03/31/10 15:07, Torsten Förtsch wrote: >> Hi, >> >> the patch below simplifies mod_perl.c a bit. >> >> Instead of >> >> modperl_response_handler_run(r, finish) { >> do something >> if( finish ) {

Re: simplify mod_perl.c a bit

2010-04-02 Thread Philip M. Gollucci
+1 On 03/31/10 15:07, Torsten Förtsch wrote: Hi, the patch below simplifies mod_perl.c a bit. Instead of modperl_response_handler_run(r, finish) { do something if( finish ) { modperl_response_finish() } } and calling that function in one place as modperl_response_handler_run(r

simplify mod_perl.c a bit

2010-03-31 Thread Torsten Förtsch
Hi, the patch below simplifies mod_perl.c a bit. Instead of modperl_response_handler_run(r, finish) { do something if( finish ) { modperl_response_finish() } } and calling that function in one place as modperl_response_handler_run(r, TRUE) and in the second place as modperl_respons