[jira] [Commented] (PHOENIX-3295) Remove ReplaceArrayColumnWithKeyValueColumnExpressionVisitor

2016-10-09 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560604#comment-15560604 ] James Taylor commented on PHOENIX-3295: --- Thanks, [~tdsilva]. Here's some feedback:

[jira] [Updated] (PHOENIX-3295) Remove ReplaceArrayColumnWithKeyValueColumnExpressionVisitor

2016-10-09 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas D'Silva updated PHOENIX-3295: Attachment: PHOENIX-3295-v2.patch [~jamestaylor] Attached a v2 patch with ArrayColumnExpr

[jira] [Commented] (PHOENIX-476) Support declaration of DEFAULT in CREATE statement

2016-10-09 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15560493#comment-15560493 ] James Taylor commented on PHOENIX-476: -- Looking really good, [~kliew]. Thanks for th

[jira] [Comment Edited] (PHOENIX-476) Support declaration of DEFAULT in CREATE statement

2016-10-09 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15559451#comment-15559451 ] Kevin Liew edited comment on PHOENIX-476 at 10/9/16 7:03 AM: -

[jira] [Updated] (PHOENIX-476) Support declaration of DEFAULT in CREATE statement

2016-10-09 Thread Kevin Liew (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liew updated PHOENIX-476: --- Attachment: PHOENIX-476.5.patch I attached a patch with additional test coverage and all test cases p