[jira] [Commented] (PHOENIX-4198) Remove the need for users to have access to the Phoenix SYSTEM tables to create tables

2017-09-25 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179140#comment-16179140 ] Ankit Singhal commented on PHOENIX-4198: bq. Since we already acquire the requir

Re: Phoenix code quality

2017-09-25 Thread Cody Marcel
@Kevin Liew, that's a good idea. If you see places where this can be done, file a JIRA for it as this is great way to make incremental improvements. Well defined small things like this are also make for simple things for noobs to pick up and contribute. I like following the boy scout rule. Leave

Re: Phoenix code quality

2017-09-25 Thread Jan Fernando
Lars, I think these are really awesome guidelines. As Phoenix reaches a new phase of maturity and operational complexity (which is really exciting and important for the project IMHO), I think these things are becoming even more important. Re #5, I agree we need to err on the side of stability. I

Re: Phoenix code quality

2017-09-25 Thread Andrew Purtell
A model that has worked well for HBase is large feature development on a separate branch, followed by a process to do a branch merge back to the main project. The big upside is feature developers have near total freedom. The big downside is the merge can take a while to review/approve and rebasing

[jira] [Created] (PHOENIX-4229) Parent-Child linking rows in System.Catalog break tenant view replication

2017-09-25 Thread Geoffrey Jacoby (JIRA)
Geoffrey Jacoby created PHOENIX-4229: Summary: Parent-Child linking rows in System.Catalog break tenant view replication Key: PHOENIX-4229 URL: https://issues.apache.org/jira/browse/PHOENIX-4229 P

Re: Phoenix code quality

2017-09-25 Thread Andrew Purtell
Also, in my experience curating the Hadoop ecosystem (a process that starts with Apache $FOO release x.y.z, then applies individual upstream commits one patch at a time), Phoenix code is more tightly coupled than any other project I have encountered, out of: ZooKeeper, Hadoop, HBase, Pig, Hive, Spa

Re: [ANNOUNCE] New PMC Member: Sergey Soldatov

2017-09-25 Thread Josh Mahonin
Congratulations Sergey! On Sun, Sep 24, 2017 at 4:05 PM, Ted Yu wrote: > Congratulations, Sergey ! > > On Sun, Sep 24, 2017 at 1:00 PM, Josh Elser wrote: > >> All, >> >> The Apache Phoenix PMC has recently voted to extend an invitation to >> Sergey to join the PMC in recognition of his continue

[jira] [Commented] (PHOENIX-4219) Index gets out of sync on HBase 1.x

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179396#comment-16179396 ] James Taylor commented on PHOENIX-4219: --- Any further insights, [~vincentpoon]? Hav

Re: [ANNOUNCE] New PMC Member: Sergey Soldatov

2017-09-25 Thread James Taylor
Great to have you on the PMC, Sergey. Congrats! James On Mon, Sep 25, 2017 at 10:28 AM, Josh Mahonin wrote: > Congratulations Sergey! > > On Sun, Sep 24, 2017 at 4:05 PM, Ted Yu wrote: > > > Congratulations, Sergey ! > > > > On Sun, Sep 24, 2017 at 1:00 PM, Josh Elser wrote: > > > >> All,

[jira] [Created] (PHOENIX-4230) Write index updates in postBatchMutateIndispensably for transactional tables

2017-09-25 Thread James Taylor (JIRA)
James Taylor created PHOENIX-4230: - Summary: Write index updates in postBatchMutateIndispensably for transactional tables Key: PHOENIX-4230 URL: https://issues.apache.org/jira/browse/PHOENIX-4230 Proj

[jira] [Commented] (PHOENIX-672) Add GRANT and REVOKE commands using HBase AccessController

2017-09-25 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179454#comment-16179454 ] Andrew Purtell commented on PHOENIX-672: bq. how should we handle cases where nam

[jira] [Assigned] (PHOENIX-4214) Scans which write should not block region split or close

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor reassigned PHOENIX-4214: - Assignee: Vincent Poon > Scans which write should not block region split or close > ---

[jira] [Created] (PHOENIX-4231) Support restriction of remote UDF load sources

2017-09-25 Thread Andrew Purtell (JIRA)
Andrew Purtell created PHOENIX-4231: --- Summary: Support restriction of remote UDF load sources Key: PHOENIX-4231 URL: https://issues.apache.org/jira/browse/PHOENIX-4231 Project: Phoenix Iss

[jira] [Commented] (PHOENIX-4214) Scans which write should not block region split or close

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179470#comment-16179470 ] James Taylor commented on PHOENIX-4214: --- Ping [~lhofhansl]. Did you +1 this one ab

[jira] [Created] (PHOENIX-4232) Hide shadow cell and commit table access in TAL

2017-09-25 Thread James Taylor (JIRA)
James Taylor created PHOENIX-4232: - Summary: Hide shadow cell and commit table access in TAL Key: PHOENIX-4232 URL: https://issues.apache.org/jira/browse/PHOENIX-4232 Project: Phoenix Issue T

[jira] [Commented] (PHOENIX-4232) Hide shadow cell and commit table access in TAL

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179686#comment-16179686 ] James Taylor commented on PHOENIX-4232: --- FYI, [~ohads]. > Hide shadow cell and co

[jira] [Updated] (PHOENIX-4232) Hide shadow cell and commit table access in TAL

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4232: -- Labels: omid (was: ) > Hide shadow cell and commit table access in TAL >

[jira] [Commented] (PHOENIX-4214) Scans which write should not block region split or close

2017-09-25 Thread churro morales (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179728#comment-16179728 ] churro morales commented on PHOENIX-4214: - +1 lgtm > Scans which write should

[jira] [Updated] (PHOENIX-4230) Write index updates in postBatchMutateIndispensably for transactional tables

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4230: -- Attachment: PHOENIX-4230.patch Please review, [~tdsilva]. This is the equivalent change we mad

[jira] [Commented] (PHOENIX-4230) Write index updates in postBatchMutateIndispensably for transactional tables

2017-09-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179805#comment-16179805 ] Hadoop QA commented on PHOENIX-4230: {color:red}-1 overall{color}. Here are the res

[jira] [Commented] (PHOENIX-4230) Write index updates in postBatchMutateIndispensably for transactional tables

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179818#comment-16179818 ] James Taylor commented on PHOENIX-4230: --- [~elserj] - something seems wrong with ou

[jira] [Commented] (PHOENIX-4224) Automatic resending cache for HashJoin doesn't work when cache has expired on server side

2017-09-25 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179843#comment-16179843 ] Sergey Soldatov commented on PHOENIX-4224: -- I'm still thinking about whether we

[jira] [Updated] (PHOENIX-4224) Automatic resending cache for HashJoin doesn't work when cache has expired on server side

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4224: -- Priority: Major (was: Blocker) > Automatic resending cache for HashJoin doesn't work when cac

[jira] [Commented] (PHOENIX-4224) Automatic resending cache for HashJoin doesn't work when cache has expired on server side

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179860#comment-16179860 ] James Taylor commented on PHOENIX-4224: --- [~elserj] - this doesn't sound like a blo

[jira] [Commented] (PHOENIX-3815) Only disable indexes on which write failures occurred

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179874#comment-16179874 ] James Taylor commented on PHOENIX-3815: --- Ping [~vincentpoon]. Any insights? See pr

[jira] [Commented] (PHOENIX-4224) Automatic resending cache for HashJoin doesn't work when cache has expired on server side

2017-09-25 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179890#comment-16179890 ] Sergey Soldatov commented on PHOENIX-4224: -- [~jamestaylor] That's definitely a

[jira] [Commented] (PHOENIX-4224) Automatic resending cache for HashJoin doesn't work when cache has expired on server side

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179893#comment-16179893 ] James Taylor commented on PHOENIX-4224: --- Ah, ok. Thank, [~sergey.soldatov] - didn'

[jira] [Updated] (PHOENIX-4224) Automatic resending cache for HashJoin doesn't work when cache has expired on server side

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4224: -- Priority: Blocker (was: Major) > Automatic resending cache for HashJoin doesn't work when cac

[jira] [Commented] (PHOENIX-4230) Write index updates in postBatchMutateIndispensably for transactional tables

2017-09-25 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179960#comment-16179960 ] Thomas D'Silva commented on PHOENIX-4230: - +1 > Write index updates in postBatc

[jira] [Commented] (PHOENIX-4224) Automatic resending cache for HashJoin doesn't work when cache has expired on server side

2017-09-25 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179984#comment-16179984 ] Sergey Soldatov commented on PHOENIX-4224: -- [~jamestaylor] I think we can fix i

[jira] [Commented] (PHOENIX-3757) System mutex table not being created in SYSTEM namespace when namespace mapping is enabled

2017-09-25 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179988#comment-16179988 ] Karan Mehta commented on PHOENIX-3757: -- [~elserj] I can take this up. Can you provi

[jira] [Updated] (PHOENIX-4230) Write index updates in postBatchMutateIndispensably for transactional tables

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4230: -- Attachment: PHOENIX-4230_v2.patch Final patch. > Write index updates in postBatchMutateIndisp

[jira] [Commented] (PHOENIX-4224) Automatic resending cache for HashJoin doesn't work when cache has expired on server side

2017-09-25 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180098#comment-16180098 ] Josh Elser commented on PHOENIX-4224: - bq. Playing with different scenarios for larg

[jira] [Commented] (PHOENIX-3757) System mutex table not being created in SYSTEM namespace when namespace mapping is enabled

2017-09-25 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180105#comment-16180105 ] Josh Elser commented on PHOENIX-3757: - [~karanmehta93], go for it! I honestly don't

[jira] [Updated] (PHOENIX-4224) Automatic resending cache for HashJoin doesn't work when cache has expired on server side

2017-09-25 Thread Sergey Soldatov (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Soldatov updated PHOENIX-4224: - Attachment: PHOENIX-4224-1.patch simple version that tracks whether cache was supposed t

[jira] [Commented] (PHOENIX-4230) Write index updates in postBatchMutateIndispensably for transactional tables

2017-09-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180156#comment-16180156 ] Hadoop QA commented on PHOENIX-4230: {color:red}-1 overall{color}. Here are the res

[jira] [Commented] (PHOENIX-4230) Write index updates in postBatchMutateIndispensably for transactional tables

2017-09-25 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180166#comment-16180166 ] Josh Elser commented on PHOENIX-4230: - bq. something seems wrong with our pre commit

[jira] [Commented] (PHOENIX-4224) Automatic resending cache for HashJoin doesn't work when cache has expired on server side

2017-09-25 Thread Ankit Singhal (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180217#comment-16180217 ] Ankit Singhal commented on PHOENIX-4224: bq. From the end user perspective that

[jira] [Updated] (PHOENIX-4233) IndexScrutiny test tool does not work for salted and shared index tables

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4233: -- Fix Version/s: 4.12.0 > IndexScrutiny test tool does not work for salted and shared index tabl

[jira] [Assigned] (PHOENIX-4233) IndexScrutiny test tool does not work for salted and shared index tables

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor reassigned PHOENIX-4233: - Assignee: James Taylor > IndexScrutiny test tool does not work for salted and shared in

[jira] [Created] (PHOENIX-4233) IndexScrutiny test tool does not work for salted and shared index tables

2017-09-25 Thread James Taylor (JIRA)
James Taylor created PHOENIX-4233: - Summary: IndexScrutiny test tool does not work for salted and shared index tables Key: PHOENIX-4233 URL: https://issues.apache.org/jira/browse/PHOENIX-4233 Project:

[jira] [Updated] (PHOENIX-4233) IndexScrutiny test tool does not work for salted and shared index tables

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-4233: -- Attachment: PHOENIX-4233.patch Something to check for the MR-based scrutiny tool, [~vincentpoo

[jira] [Updated] (PHOENIX-3815) Only disable indexes on which write failures occurred

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-3815: -- Attachment: PHOENIX-3815_v3.patch Rebased patch and made the following changes: - Use Parallel

[jira] [Commented] (PHOENIX-4224) Automatic resending cache for HashJoin doesn't work when cache has expired on server side

2017-09-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180290#comment-16180290 ] Hadoop QA commented on PHOENIX-4224: {color:red}-1 overall{color}. Here are the res

[jira] [Updated] (PHOENIX-4007) Surface time at which byte/row estimate information was computed in explain plan output

2017-09-25 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4007: -- Attachment: PHOENIX-4007_v9.patch Updated patch with additional tests that check for the exact

[jira] [Commented] (PHOENIX-4007) Surface time at which byte/row estimate information was computed in explain plan output

2017-09-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180316#comment-16180316 ] Hadoop QA commented on PHOENIX-4007: {color:red}-1 overall{color}. Here are the res

[jira] [Commented] (PHOENIX-4007) Surface time at which byte/row estimate information was computed in explain plan output

2017-09-25 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180320#comment-16180320 ] James Taylor commented on PHOENIX-4007: --- bq. In this patch I have removed the init