Github user karanmehta93 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206412733
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java ---
@@ -82,6 +82,10 @@
static final String SYSTEM_SEQUENC
Github user twdsilva commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206411967
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -3604,6 +3681,18 @@ public MutationState addColumn(PTable table,
GitHub user comnetwork opened a pull request:
https://github.com/apache/phoenix/pull/320
PHOENIX-4820
This patch is mainly for:
1.Isolate the changes made for QueryCompiler to OrderByCompiler.
2.Check more Expression besides ComparisonExpression for
IsColumnConstantExpr
Github user comnetwork commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/314#discussion_r206382301
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java ---
@@ -559,8 +559,16 @@ protected QueryPlan
compileSingleFlatQuery(S
Github user geraldss commented on the issue:
https://github.com/apache/phoenix/pull/308
Thanks @JamesRTaylor for the reviews and suggestions.
---
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/314#discussion_r206377190
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java ---
@@ -559,8 +559,16 @@ protected QueryPlan
compileSingleFlatQuery(S
Github user karanmehta93 commented on the issue:
https://github.com/apache/phoenix/pull/315
Addressed your comments @joshelser, Please review!
---
Hi all,
(Yes, this was sent to dev. As long as we have nothing private included,
I think it's a nice transparency "thing" to have this discussion in public.)
Please send me information that you think should be included in the
upcoming board report.
You can find May's report at
https://whim
Github user JamesRTaylor commented on the issue:
https://github.com/apache/phoenix/pull/308
+1. Nice work, @geraldss. @twdsilva - would you (or maybe someone else?)
have some spare cycles to check this in assuming the test run comes back clean?
---
Github user ankitsinghal commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/313#discussion_r206330492
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -3604,6 +3681,18 @@ public MutationState addColumn(PTable tab
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/317#discussion_r206328431
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/ExplainTable.java ---
@@ -204,14 +205,19 @@ private void appendPKColumnValue(StringBuil
Github user geraldss commented on the issue:
https://github.com/apache/phoenix/pull/308
@JamesRTaylor - Handled reverse sort; added explanatory comments about
sorting; added tests for sorting and non-sorting, including EXPLAIN.
Pushed changes; uploaded new .patch file; resubmi
[
https://issues.apache.org/jira/browse/PHOENIX-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gerald Sangudi updated PHOENIX-4751:
Attachment: 0016-PHOENIX-4751-Handle-reverse-sort-add-c.4.x-HBase-1.4.patch
> Support cli
Ankit Singhal created PHOENIX-4828:
--
Summary: Remove dependency on HBase interfaces of type
InterfaceAudience.Private
Key: PHOENIX-4828
URL: https://issues.apache.org/jira/browse/PHOENIX-4828
Project
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/317#discussion_r206326382
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1431,11 +1438,42 @@ private PTable getTable(Regi
Github user m2je commented on the issue:
https://github.com/apache/phoenix/pull/317
Thanks @twdsilva for the review and feed backs.
I'll wait for for your teams feed back on proposed change to VIEW_INDEX_ID
column and soon after getting the confirmation, I'll update this PR.
---
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/308#discussion_r206295564
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java
---
@@ -135,17 +142,25 @@ public ResultIterator iterator(Para
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/308#discussion_r206295347
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ClientHashAggregateIT.java
---
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/PHOENIX-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gerald Sangudi updated PHOENIX-4751:
Attachment: 0015-PHOENIX-4751-Show-client-hash-aggregat.4.x-HBase-1.4.patch
[
https://issues.apache.org/jira/browse/PHOENIX-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gerald Sangudi updated PHOENIX-4751:
Attachment: (was: PHOENIX-4751-4.x-HBase-1.4.patch)
> Support client-side hash aggreg
James Taylor created PHOENIX-4827:
-
Summary: Modify TAL to use Table instead of HTableInterface
Key: PHOENIX-4827
URL: https://issues.apache.org/jira/browse/PHOENIX-4827
Project: Phoenix
Issu
Github user geraldss commented on the issue:
https://github.com/apache/phoenix/pull/308
@JamesRTaylor - Done. I switched the PR to 4.x-HBase-1.4, attached the
.patch file, and issued "Submit Patch".
---
[
https://issues.apache.org/jira/browse/PHOENIX-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gerald Sangudi updated PHOENIX-4751:
Attachment: (was: PHOENIX-4751.patch)
> Support client-side hash aggregation with SOR
[
https://issues.apache.org/jira/browse/PHOENIX-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gerald Sangudi updated PHOENIX-4751:
Attachment: (was: PHOENIX-4751.patch)
> Support client-side hash aggregation with SOR
[
https://issues.apache.org/jira/browse/PHOENIX-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gerald Sangudi updated PHOENIX-4751:
Attachment: PHOENIX-4751-4.x-HBase-1.4.patch
> Support client-side hash aggregation with
[
https://issues.apache.org/jira/browse/PHOENIX-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gerald Sangudi updated PHOENIX-4751:
Attachment: PHOENIX-4751.patch
> Support client-side hash aggregation with SORT_MERGE_JOI
[
https://issues.apache.org/jira/browse/PHOENIX-4826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Singhal updated PHOENIX-4826:
---
Summary: Changes to support HBase 2.0.1 (was: Changes to support 2.0.1)
> Changes to suppo
[
https://issues.apache.org/jira/browse/PHOENIX-4826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Singhal updated PHOENIX-4826:
---
Attachment: PHOENIX-4826.patch
> Changes to support 2.0.1
>
>
>
Ankit Singhal created PHOENIX-4826:
--
Summary: Changes to support 2.0.1
Key: PHOENIX-4826
URL: https://issues.apache.org/jira/browse/PHOENIX-4826
Project: Phoenix
Issue Type: Task
[
https://issues.apache.org/jira/browse/PHOENIX-4823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser updated PHOENIX-4823:
Fix Version/s: (was: 5.0.0)
5.1.0
> Issue with Maven Dependencies
> --
[
https://issues.apache.org/jira/browse/PHOENIX-4825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Singhal updated PHOENIX-4825:
---
Attachment: PHOENIX-4825.patch
> Replace usage of HBase Base64 implementation with java.uti
[
https://issues.apache.org/jira/browse/PHOENIX-4825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ankit Singhal updated PHOENIX-4825:
---
Summary: Replace usage of HBase Base64 implementation with java.util.Base64
(was: Replace
Ankit Singhal created PHOENIX-4825:
--
Summary: Replace usage of our Base64 implementation with
java.util.Base64
Key: PHOENIX-4825
URL: https://issues.apache.org/jira/browse/PHOENIX-4825
Project: Phoen
[
https://issues.apache.org/jira/browse/PHOENIX-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas D'Silva reassigned PHOENIX-4476:
---
Assignee: Xu Cang
> Range scan used for point lookups if filter is not in order of
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206259317
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java ---
@@ -204,6 +219,39 @@ private static void resetGlobalMetrics() {
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206259129
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalClientMetrics.java
---
@@ -108,40 +114,88 @@
GLOBAL_HBASE_COUNT_ROWS_SC
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/315#discussion_r206259200
--- Diff: phoenix-core/src/test/resources/hadoop-metrics2.properties ---
@@ -32,10 +32,9 @@
#[prefix].[source|sink].[instance].[options]
# Se
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/318
@jimmycasey can you create a corresponding Jira issue under the PHOENIX
project using https://issues.apache.org/jira/secure/CreateIssue.jspa, please?
We do our project mgmt/release tracking on Jir
Done. I can't seem to find a way to figure out who the moderators of the
currents lists are, so I put down myself, James (sorry ^.^), and Thomas ;)
On 2018/07/26 17:39:49, "Thomas D'Silva" wrote:
> Josh,
Only apache members or pmc chairs can create a new mailing list (
https://selfserve.apac
[
https://issues.apache.org/jira/browse/PHOENIX-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chenglei updated PHOENIX-4820:
--
Attachment: PHOENIX-4820_v2.patch
> Optimize OrderBy for ClientAggregatePlan
> --
GitHub user comnetwork opened a pull request:
https://github.com/apache/phoenix/pull/319
PHOENIX-4820_V2
This Patch is mainly for:
1. Isolate the changes made for QueryCompiler to OrderByCompiler.
2. Check more Expression besides ComparisonExpression for
IsColumnConstantExp
41 matches
Mail list logo
