stoty commented on pull request #112:
URL: https://github.com/apache/phoenix-tephra/pull/112#issuecomment-822144285
1. There seems to be a pom error that causes the test to fail.
2. Did you have to make changes in the code for 2.4 compared to 2.3 ? If
not, then it'd be better to
richardantal opened a new pull request #112:
URL: https://github.com/apache/phoenix-tephra/pull/112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
stoty closed pull request #92:
URL: https://github.com/apache/phoenix-omid/pull/92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
joshelser commented on a change in pull request #92:
URL: https://github.com/apache/phoenix-omid/pull/92#discussion_r599858949
##
File path:
transaction-client/src/main/java/org/apache/omid/tso/client/TSOClient.java
##
@@ -1012,37 +1016,34 @@ private void
joshelser commented on a change in pull request #92:
URL: https://github.com/apache/phoenix-omid/pull/92#discussion_r599858525
##
File path:
transaction-client/src/main/java/org/apache/omid/tso/client/TSOClient.java
##
@@ -342,7 +344,7 @@ public void nodeChanged() throws
stoty commented on a change in pull request #92:
URL: https://github.com/apache/phoenix-omid/pull/92#discussion_r597911135
##
File path:
transaction-client/src/main/java/org/apache/omid/tso/client/TSOClient.java
##
@@ -513,7 +515,7 @@ void decrementRetries() {
}
joshelser commented on a change in pull request #92:
URL: https://github.com/apache/phoenix-omid/pull/92#discussion_r597882282
##
File path:
transaction-client/src/main/java/org/apache/omid/tso/client/TSOClient.java
##
@@ -342,7 +344,7 @@ public void nodeChanged() throws
stoty opened a new pull request #92:
URL: https://github.com/apache/phoenix-omid/pull/92
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chrajeshbabu closed pull request #89:
URL: https://github.com/apache/phoenix-omid/pull/89
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
stoty commented on pull request #74:
URL: https://github.com/apache/phoenix-omid/pull/74#issuecomment-792790258
Closing this as we have a fix for the root cause with dynamic port
allocation.
This is an automated message
stoty closed pull request #91:
URL: https://github.com/apache/phoenix-omid/pull/91
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
stoty commented on a change in pull request #89:
URL: https://github.com/apache/phoenix-omid/pull/89#discussion_r582668337
##
File path:
tso-server/src/test/java/org/apache/omid/tso/TestTSOChannelHandlerNetty.java
##
@@ -70,186 +72,197 @@
private
RequestProcessor
stoty commented on a change in pull request #89:
URL: https://github.com/apache/phoenix-omid/pull/89#discussion_r582666495
##
File path:
hbase-client/src/test/java/org/apache/omid/transaction/OmidTestBase.java
##
@@ -99,12 +102,12 @@ public void beforeGroups(ITestContext
stoty opened a new pull request #91:
URL: https://github.com/apache/phoenix-omid/pull/91
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chrajeshbabu commented on pull request #89:
URL: https://github.com/apache/phoenix-omid/pull/89#issuecomment-785460431
@stoty handled the review comment and fixed the failing test cases. Please
take a look. Thanks
This is
stoty opened a new pull request #90:
URL: https://github.com/apache/phoenix-omid/pull/90
…n.getCurrentUser()
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chrajeshbabu commented on pull request #89:
URL: https://github.com/apache/phoenix-omid/pull/89#issuecomment-780522059
> Usually this construct is used to generate a free port:
>
>
stoty commented on pull request #89:
URL: https://github.com/apache/phoenix-omid/pull/89#issuecomment-780499275
Usually this construct is used to generate a free port:
chrajeshbabu edited a comment on pull request #89:
URL: https://github.com/apache/phoenix-omid/pull/89#issuecomment-780482831
@stoty @chia7712 took some simple step of creating random number between
1050 to 2 and use as a random port number in tests not changing any core.
WDYT?
chrajeshbabu edited a comment on pull request #89:
URL: https://github.com/apache/phoenix-omid/pull/89#issuecomment-780482831
@stoty took some simple step of creating random number between 1050 to 2
and use as a random port number in tests not changing any core. WDYT?
chrajeshbabu commented on pull request #89:
URL: https://github.com/apache/phoenix-omid/pull/89#issuecomment-780482831
@stoty took some simple step of creating random number between 1050 to 2
and use as a random port number in the tests. WDYT?
chrajeshbabu opened a new pull request #89:
URL: https://github.com/apache/phoenix-omid/pull/89
…n the tests(Rajeshbabu)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chrajeshbabu closed pull request #88:
URL: https://github.com/apache/phoenix-omid/pull/88
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chrajeshbabu commented on pull request #88:
URL: https://github.com/apache/phoenix-omid/pull/88#issuecomment-780472894
Pushed to master. Thanks for review @stoty @virajjasani .
This is an automated message from the Apache
chrajeshbabu commented on pull request #88:
URL: https://github.com/apache/phoenix-omid/pull/88#issuecomment-779787578
The test failures are not related to it.
This is an automated message from the Apache Git Service.
To
chrajeshbabu commented on pull request #88:
URL: https://github.com/apache/phoenix-omid/pull/88#issuecomment-779322348
> Come to think of it, we may update mockito as well.
we can rebase to 1.10.9 Istvan. Will make the changes.
stoty commented on pull request #88:
URL: https://github.com/apache/phoenix-omid/pull/88#issuecomment-779299728
Come to think of it, we may update mockito as well.
This is an automated message from the Apache Git Service.
To
chrajeshbabu opened a new pull request #88:
URL: https://github.com/apache/phoenix-omid/pull/88
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chrajeshbabu closed pull request #87:
URL: https://github.com/apache/phoenix-omid/pull/87
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chrajeshbabu commented on pull request #87:
URL: https://github.com/apache/phoenix-omid/pull/87#issuecomment-778664836
Build failure is not related to this.
This is an automated message from the Apache Git Service.
To
chrajeshbabu commented on a change in pull request #87:
URL: https://github.com/apache/phoenix-omid/pull/87#discussion_r575697146
##
File path: hbase-client/pom.xml
##
@@ -117,6 +117,12 @@
${testng.version}
test
+
Review comment:
stoty commented on a change in pull request #87:
URL: https://github.com/apache/phoenix-omid/pull/87#discussion_r575696741
##
File path: hbase-client/pom.xml
##
@@ -117,6 +117,12 @@
${testng.version}
test
+
Review comment:
stoty commented on a change in pull request #87:
URL: https://github.com/apache/phoenix-omid/pull/87#discussion_r575696615
##
File path: hbase-client/pom.xml
##
@@ -117,6 +117,12 @@
${testng.version}
test
+
Review comment:
chrajeshbabu opened a new pull request #87:
URL: https://github.com/apache/phoenix-omid/pull/87
…ts(Rajeshbabu)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chrajeshbabu commented on pull request #86:
URL: https://github.com/apache/phoenix-omid/pull/86#issuecomment-776581090
merged the changes.
This is an automated message from the Apache Git Service.
To respond to the message,
chrajeshbabu closed pull request #86:
URL: https://github.com/apache/phoenix-omid/pull/86
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
stoty commented on a change in pull request #86:
URL: https://github.com/apache/phoenix-omid/pull/86#discussion_r573574363
##
File path:
hbase-common/src/main/java/org/apache/omid/tools/hbase/HBaseLogin.java
##
@@ -29,27 +33,95 @@
private static final Logger LOG =
chrajeshbabu commented on a change in pull request #86:
URL: https://github.com/apache/phoenix-omid/pull/86#discussion_r573566977
##
File path:
hbase-common/src/main/java/org/apache/omid/tools/hbase/HBaseLogin.java
##
@@ -29,27 +33,95 @@
private static final Logger LOG =
chrajeshbabu commented on pull request #86:
URL: https://github.com/apache/phoenix-omid/pull/86#issuecomment-776564359
> SecureUserConnectionsIT in Phoenix could probably be adopted easily.
Will raise separate issue for test cases and add those.
chrajeshbabu commented on pull request #86:
URL: https://github.com/apache/phoenix-omid/pull/86#issuecomment-776563869
> .. but don't have the hbase client principal/keytab configuration set? If
it doesnt' work, that's fine, but we should be clear about what is expected to
work (e.g. on
stoty edited a comment on pull request #86:
URL: https://github.com/apache/phoenix-omid/pull/86#issuecomment-775750181
Let me recap what I see:
The original problem was that the old code didnt't check for a pre-existing
kerberos ugi, and forced logging in with the provided
stoty commented on a change in pull request #86:
URL: https://github.com/apache/phoenix-omid/pull/86#discussion_r572663951
##
File path:
hbase-common/src/main/java/org/apache/omid/tools/hbase/HBaseLogin.java
##
@@ -29,27 +33,95 @@
private static final Logger LOG =
stoty commented on pull request #86:
URL: https://github.com/apache/phoenix-omid/pull/86#issuecomment-775750181
Let me recap what I see:
The original problem was that the old code didnt't check for a pre-existing
kerberos ugi, and forced logging in with the provided credentials,
chrajeshbabu opened a new pull request #86:
URL: https://github.com/apache/phoenix-omid/pull/86
…n kerberos cluster(Rajeshbabu)
This is an automated message from the Apache Git Service.
To respond to the message, please log
stoty commented on pull request #2:
URL: https://github.com/apache/phoenix-thirdparty/pull/2#issuecomment-769901801
Thanks for the reviews @virajjasani @joshelser
This is an automated message from the Apache Git Service.
To
stoty closed pull request #2:
URL: https://github.com/apache/phoenix-thirdparty/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stoty commented on a change in pull request #2:
URL: https://github.com/apache/phoenix-thirdparty/pull/2#discussion_r566914728
##
File path: phoenix-shaded-commons-cli/pom.xml
##
@@ -0,0 +1,169 @@
+
+http://maven.apache.org/POM/4.0.0;
stoty commented on a change in pull request #2:
URL: https://github.com/apache/phoenix-thirdparty/pull/2#discussion_r566914728
##
File path: phoenix-shaded-commons-cli/pom.xml
##
@@ -0,0 +1,169 @@
+
+http://maven.apache.org/POM/4.0.0;
stoty commented on a change in pull request #2:
URL: https://github.com/apache/phoenix-thirdparty/pull/2#discussion_r566913947
##
File path: phoenix-shaded-commons-cli/pom.xml
##
@@ -0,0 +1,169 @@
+
+http://maven.apache.org/POM/4.0.0;
joshelser commented on a change in pull request #2:
URL: https://github.com/apache/phoenix-thirdparty/pull/2#discussion_r566902974
##
File path: phoenix-shaded-commons-cli/pom.xml
##
@@ -0,0 +1,169 @@
+
+http://maven.apache.org/POM/4.0.0;
stoty commented on a change in pull request #2:
URL: https://github.com/apache/phoenix-thirdparty/pull/2#discussion_r566861825
##
File path: phoenix-shaded-commons-cli/src/main/patches/CLI-254-1.4.patch
##
@@ -0,0 +1,72 @@
+diff --git
stoty commented on a change in pull request #2:
URL: https://github.com/apache/phoenix-thirdparty/pull/2#discussion_r566861825
##
File path: phoenix-shaded-commons-cli/src/main/patches/CLI-254-1.4.patch
##
@@ -0,0 +1,72 @@
+diff --git
virajjasani commented on a change in pull request #2:
URL: https://github.com/apache/phoenix-thirdparty/pull/2#discussion_r566834894
##
File path: phoenix-shaded-commons-cli/src/main/patches/CLI-254-1.4.patch
##
@@ -0,0 +1,72 @@
+diff --git
virajjasani commented on a change in pull request #2:
URL: https://github.com/apache/phoenix-thirdparty/pull/2#discussion_r566820054
##
File path: phoenix-shaded-commons-cli/src/main/patches/CLI-254-1.4.patch
##
@@ -0,0 +1,72 @@
+diff --git
stoty opened a new pull request #2:
URL: https://github.com/apache/phoenix-thirdparty/pull/2
includes a patch that lets us disable the double quote removing "feature"
This is an automated message from the Apache Git Service.
stoty closed pull request #85:
URL: https://github.com/apache/phoenix-omid/pull/85
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
richardantal opened a new pull request #85:
URL: https://github.com/apache/phoenix-omid/pull/85
Change-Id: I3fbecd481df0d9994ca41791761daf29573711f7
This is an automated message from the Apache Git Service.
To respond to the
stoty commented on pull request #80:
URL: https://github.com/apache/phoenix-omid/pull/80#issuecomment-748459260
Committed with rebase and minor changes
This is an automated message from the Apache Git Service.
To respond to
stoty closed pull request #80:
URL: https://github.com/apache/phoenix-omid/pull/80
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
stoty commented on pull request #80:
URL: https://github.com/apache/phoenix-omid/pull/80#issuecomment-748458644
This is still not a maven setup that I am completely happy with, but it's
certainly a step in the right direction.
I've rebased this on master, and successfully tested
stoty opened a new pull request #84:
URL: https://github.com/apache/phoenix-omid/pull/84
Rebase of Chia-Ping Tsai 's original PR for testing
This is an automated message from the Apache Git Service.
To respond to the
stoty closed pull request #83:
URL: https://github.com/apache/phoenix-omid/pull/83
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
richardantal commented on pull request #83:
URL: https://github.com/apache/phoenix-omid/pull/83#issuecomment-738756396
LGTM
Thanks @stoty for the quick fix
This is an automated message from the Apache Git Service.
To
stoty opened a new pull request #83:
URL: https://github.com/apache/phoenix-omid/pull/83
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
richardantal closed pull request #111:
URL: https://github.com/apache/phoenix-tephra/pull/111
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
richardantal opened a new pull request #111:
URL: https://github.com/apache/phoenix-tephra/pull/111
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
stoty commented on pull request #82:
URL: https://github.com/apache/phoenix-omid/pull/82#issuecomment-736992438
Thanks for the fix @richardantal
Committed with some changes.
This is an automated message from the Apache
stoty closed pull request #82:
URL: https://github.com/apache/phoenix-omid/pull/82
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
stoty commented on a change in pull request #82:
URL: https://github.com/apache/phoenix-omid/pull/82#discussion_r533897088
##
File path: pom.xml
##
@@ -250,6 +251,7 @@
maven-assembly-plugin
+
stoty commented on pull request #76:
URL: https://github.com/apache/phoenix-omid/pull/76#issuecomment-736983824
Thanks @chia7712
I am super busy now, so non-blocker Omid reviews from me will probably be
delayed.
Maybe someone else will step up and review.
chia7712 commented on pull request #76:
URL: https://github.com/apache/phoenix-omid/pull/76#issuecomment-736672678
@stoty Please take a look. I have rebase the code
This is an automated message from the Apache Git Service.
richardantal opened a new pull request #82:
URL: https://github.com/apache/phoenix-omid/pull/82
Change-Id: I63aeb3848e94c4c3fedfb2466e037f4211395002
This is an automated message from the Apache Git Service.
To respond to the
stoty closed pull request #110:
URL: https://github.com/apache/phoenix-tephra/pull/110
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stoty commented on pull request #81:
URL: https://github.com/apache/phoenix-omid/pull/81#issuecomment-732722404
I'm not sure what to do about the readme, especially about the coveralls
integration.
This is an automated
stoty closed pull request #81:
URL: https://github.com/apache/phoenix-omid/pull/81
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
stoty commented on pull request #81:
URL: https://github.com/apache/phoenix-omid/pull/81#issuecomment-732027448
Minimum changeset to get the links working.
No changes in website content otherwise.
This is an automated
stoty opened a new pull request #81:
URL: https://github.com/apache/phoenix-omid/pull/81
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chia7712 commented on pull request #76:
URL: https://github.com/apache/phoenix-omid/pull/76#issuecomment-730967693
rebase code
This is an automated message from the Apache Git Service.
To respond to the message, please log
chia7712 edited a comment on pull request #80:
URL: https://github.com/apache/phoenix-omid/pull/80#issuecomment-728748262
> but I'll need to test this with Phoenix.
thanks for the testing! Some artifact has postfix (hbase-x) now so it may
break some dependency rules of downstream.
chia7712 commented on pull request #80:
URL: https://github.com/apache/phoenix-omid/pull/80#issuecomment-728748262
> but I'll need to test this with Phoenix.
thanks for the testing!
This is an automated message from
stoty commented on pull request #80:
URL: https://github.com/apache/phoenix-omid/pull/80#issuecomment-728747718
This looks like a step in the right direction. but I'll need to test this
with Phoenix.
This is an automated
stoty opened a new pull request #110:
URL: https://github.com/apache/phoenix-tephra/pull/110
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 edited a comment on pull request #80:
URL: https://github.com/apache/phoenix-omid/pull/80#issuecomment-727801984
@stoty following is response to your comment of
chia7712 commented on pull request #80:
URL: https://github.com/apache/phoenix-omid/pull/80#issuecomment-727801984
> Doesn't need the exclusion hack that we need now
done
> Can build both the HBase 1 and 2 artifacts in one pass
Not sure whether this is necessary since
chia7712 opened a new pull request #80:
URL: https://github.com/apache/phoenix-omid/pull/80
issue: https://issues.apache.org/jira/browse/OMID-188
The main changes are shown below.
1. all artifact has postfix (hbase-1 or hbase-2): phoenix-omid supports both
hbase-1 and hbase-2
richardantal closed pull request #1:
URL: https://github.com/apache/phoenix-thirdparty/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
stoty closed pull request #79:
URL: https://github.com/apache/phoenix-omid/pull/79
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
stoty closed pull request #70:
URL: https://github.com/apache/phoenix-omid/pull/70
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
stoty closed pull request #109:
URL: https://github.com/apache/phoenix-tephra/pull/109
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stoty commented on pull request #109:
URL: https://github.com/apache/phoenix-tephra/pull/109#issuecomment-726549909
Thank you.
I have renamed the ticket and the commit message, as this ended up smaller
in scope than I originally intended,
chia7712 commented on pull request #73:
URL: https://github.com/apache/phoenix-omid/pull/73#issuecomment-726488765
duplicate to #79
This is an automated message from the Apache Git Service.
To respond to the message, please
chia7712 closed pull request #73:
URL: https://github.com/apache/phoenix-omid/pull/73
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chia7712 opened a new pull request #79:
URL: https://github.com/apache/phoenix-omid/pull/79
issue: https://issues.apache.org/jira/browse/OMID-187
https://git-wip-us.apache.org/repos/asf/incubator-omid.git is not available
and the replacement is
chia7712 opened a new pull request #78:
URL: https://github.com/apache/phoenix-omid/pull/78
issue: https://issues.apache.org/jira/browse/OMID-173
Run this patch with #76 and all warnings of statemachine module are fixed.
chia7712 opened a new pull request #77:
URL: https://github.com/apache/phoenix-omid/pull/77
issue: https://issues.apache.org/jira/browse/OMID-171
Run this patch with #76 and all warnings of common module are fixed.
stoty closed pull request #108:
URL: https://github.com/apache/phoenix-tephra/pull/108
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chia7712 opened a new pull request #76:
URL: https://github.com/apache/phoenix-omid/pull/76
issue: https://issues.apache.org/jira/browse/OMID-170
This is an automated message from the Apache Git Service.
To respond to the
stoty opened a new pull request #109:
URL: https://github.com/apache/phoenix-tephra/pull/109
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
stoty commented on a change in pull request #74:
URL: https://github.com/apache/phoenix-omid/pull/74#discussion_r522091256
##
File path: common/src/main/java/org/apache/omid/NetworkUtils.java
##
@@ -17,15 +17,19 @@
*/
package org.apache.omid;
+import org.slf4j.Logger;
chia7712 commented on a change in pull request #74:
URL: https://github.com/apache/phoenix-omid/pull/74#discussion_r522085070
##
File path: common/src/main/java/org/apache/omid/NetworkUtils.java
##
@@ -17,15 +17,19 @@
*/
package org.apache.omid;
+import org.slf4j.Logger;
101 - 200 of 270 matches
Mail list logo
