Github user aertoria commented on the issue:
https://github.com/apache/phoenix/pull/292
Sent out another patch for review. Let us close this p.r.
---
Github user aertoria commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/292#discussion_r170755367
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java ---
@@ -907,10 +909,15 @@ public MutationState execute() throws
Github user aertoria commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/292#discussion_r170387933
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/function/UDFExpression.java
---
@@ -198,18 +199,26 @@ public static DynamicClassLoader
Github user aertoria commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/292#discussion_r169509766
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java ---
@@ -907,10 +909,15 @@ public MutationState execute() throws
Github user aertoria commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/292#discussion_r169213703
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/UserDefinedFunctionsIT.java
---
@@ -322,6 +327,99 @@ public void testDeleteJar() throws
Github user aertoria commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/292#discussion_r166491289
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java ---
@@ -907,10 +909,15 @@ public MutationState execute() throws
Github user aertoria commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/292#discussion_r166487244
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java ---
@@ -907,10 +909,15 @@ public MutationState execute() throws
GitHub user aertoria opened a pull request:
https://github.com/apache/phoenix/pull/287
PHOENIX-4370 Surface hbase metrics from perconnection to global metrics
PHOENIX-4370 Surface hbase metrics from perconnection to global metrics
Opening this p.r. for the connivence
Github user aertoria commented on the issue:
https://github.com/apache/phoenix/pull/262
Closing this P.R. as it has been merged.
---
Github user aertoria closed the pull request at:
https://github.com/apache/phoenix/pull/262
---
Github user aertoria commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/282#discussion_r151541162
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -1940,7 +1940,8 @@ private void setTransactional
Github user aertoria commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146990595
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2526,8 +2541,14 @@ private void
Github user aertoria commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146687243
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -3101,49 +3124,68 @@ void
Github user aertoria commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/277#discussion_r146682331
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -3101,49 +3124,68 @@ void
Github user aertoria commented on the issue:
https://github.com/apache/phoenix/pull/262
Commit 0507d4f change list:
1, explain plan a new way (Thanks for the suggestion)
2, squash previous four commit into one
3, revise all commit message to start with PHOENIX-153+space
Github user aertoria commented on the issue:
https://github.com/apache/phoenix/pull/262
The last changes (if we are referring to explain plan change etc) has
already been done and went with the last commits.
I'm now rebase with the latest phoenix master and squash all commits
Github user aertoria commented on the issue:
https://github.com/apache/phoenix/pull/262
New patch summary:
1, Rebased.
2, Adding in plan explain for table sample, as well as corresponding test
cases.
example:
```
CLIENT 3-CHUNK 30 ROWS 2370 BYTES PARALLEL 1-WAY
Github user aertoria commented on the issue:
https://github.com/apache/phoenix/pull/262
Sounds good. I will start prepare another patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user aertoria commented on the issue:
https://github.com/apache/phoenix/pull/262
> See ExplainTable and let's figure out the best place to add this.
Purposing adding this logic at `BaseResultIterators`.`explain()` method.
Which is between **Line1080** and **Line1
Github user aertoria commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/262#discussion_r126782179
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/QueryCompiler.java ---
@@ -539,6 +539,7 @@ protected QueryPlan
compileSingleFlatQuery
Github user aertoria commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/262#discussion_r126779607
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryWithTableSampleIT.java
---
@@ -0,0 +1,261 @@
+/*
+ * Licensed to the Apache
Github user aertoria commented on the issue:
https://github.com/apache/phoenix/pull/262
@JamesRTaylor @gjacoby126 @samarthjain
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user aertoria opened a pull request:
https://github.com/apache/phoenix/pull/262
PHOENIX 153 implement TABLESAMPLE clause
table sampling on each Table basis (at the 'FROM' part of the query).
Sample size decided by the input sampling rate applies on Primary Key's
frequency
23 matches
Mail list logo
