[GitHub] phoenix pull request #257: PHOENIX-3917 Change to calculate query projection...

Github user bijugs closed the pull request at: https://github.com/apache/phoenix/pull/257 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] phoenix issue #257: PHOENIX-3917 Change to calculate query projection size

Github user bijugs commented on the issue: https://github.com/apache/phoenix/pull/257 Closing the PR since the Jira ticket got resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] phoenix pull request #258: PHOENIX-3921 Change the condition checking in Sca...

GitHub user bijugs opened a pull request: https://github.com/apache/phoenix/pull/258 PHOENIX-3921 Change the condition checking in ScanUtil#isReversed The current logic will return ``isReversed`` as ``true`` whether the ``BaseScannerRegionObserver.REVERSE_SCAN`` attribute is set to

[GitHub] phoenix pull request #257: PHOENIX-3917 Change to calculate query projection...

GitHub user bijugs opened a pull request: https://github.com/apache/phoenix/pull/257 PHOENIX-3917 Change to calculate query projection size Change to perform the size estimation of query row projector after all the conditions to add ``column families`` to the query ``scan`` object

[GitHub] phoenix pull request #249: PHOENIX-3878 Add license headers missed in PHOENI...

GitHub user bijugs opened a pull request: https://github.com/apache/phoenix/pull/249 PHOENIX-3878 Add license headers missed in PHOENIX-3572 Add Apache license headers missed in ``PHOENIX-3572``. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] phoenix pull request #229: PHOENIX-3572 Support FETCH NEXT|n ROWS query on c...

Github user bijugs closed the pull request at: https://github.com/apache/phoenix/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] phoenix issue #229: PHOENIX-3572 Support FETCH NEXT|n ROWS query on cursor

Github user bijugs commented on the issue: https://github.com/apache/phoenix/pull/229 Closing the PR since the patch got merged. Thanks @ankitsinghal , @JamesRTaylor . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] phoenix issue #229: PHOENIX-3572 Support FETCH NEXT|n ROWS query on cursor

Github user bijugs commented on the issue: https://github.com/apache/phoenix/pull/229 Attached patch for the changes to the JIRA ticket. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] phoenix issue #229: PHOENIX-3572 Support FETCH NEXT|n ROWS query on cursor

Github user bijugs commented on the issue: https://github.com/apache/phoenix/pull/229 @ankitsinghal , @JamesRTaylor , updated the PR with the changes for the latest review comments. If there are any other comments please let me know. Once review is complete will submit a ``diff`` to

[GitHub] phoenix pull request #229: PHOENIX-3572 Support FETCH NEXT|n ROWS query on c...

Github user bijugs commented on a diff in the pull request: https://github.com/apache/phoenix/pull/229#discussion_r113034318 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/CursorWithRowValueConstructorIT.java --- @@ -0,0 +1,687 @@ +/* + * Licensed to the

[GitHub] phoenix pull request #229: PHOENIX-3572 Support FETCH NEXT|n ROWS query on c...

Github user bijugs commented on a diff in the pull request: https://github.com/apache/phoenix/pull/229#discussion_r113033881 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/CursorWithRowValueConstructorIT.java --- @@ -0,0 +1,687 @@ +/* + * Licensed to the

[GitHub] phoenix pull request #229: PHOENIX-3572 Support FETCH NEXT|n ROWS query on c...

Github user bijugs commented on a diff in the pull request: https://github.com/apache/phoenix/pull/229#discussion_r113032806 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/QueryPlan.java --- @@ -59,6 +60,8 @@ * Returns projector used to formulate

[GitHub] phoenix pull request #229: PHOENIX-3572 Support FETCH NEXT|n ROWS query on c...

Github user bijugs commented on a diff in the pull request: https://github.com/apache/phoenix/pull/229#discussion_r113032237 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/CursorResultIterator.java --- @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache

[GitHub] phoenix issue #229: PHOENIX-3572 Support FETCH NEXT|n ROWS query on cursor

Github user bijugs commented on the issue: https://github.com/apache/phoenix/pull/229 @ankitsinghal, Thanks for the review comments. I have made the changes for the comments. Will rebase the code to a single commit once the review process is complete. --- If your project is set up

[GitHub] phoenix pull request #229: PHOENIX-3572 Support FETCH NEXT|n ROWS query on c...

GitHub user bijugs opened a pull request: https://github.com/apache/phoenix/pull/229 PHOENIX-3572 Support FETCH NEXT|n ROWS query on cursor Refer PR #192 for earlier discussion on cursor implementation. As mentioned in the title, this PR implements a sub set of ``cursor`` feature