[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

2018-05-30 Thread churrodog
Github user churrodog commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191948329 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/DropColumnIT.java --- @@ -522,7 +523,8 @@ public void

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

2018-05-30 Thread churrodog
Github user churrodog commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191948951 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/WhereConstantParser.java --- @@ -0,0 +1,113 @@ +/** + * Licensed to the

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

2018-05-30 Thread churrodog
Github user churrodog commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191948812 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java --- @@ -787,7 +787,7 @@ public MutationPlan compile(UpsertStatement

[GitHub] phoenix pull request #303: PHOENIX-3534 Support multi region SYSTEM.CATALOG ...

2018-05-30 Thread churrodog
Github user churrodog commented on a diff in the pull request: https://github.com/apache/phoenix/pull/303#discussion_r191948510 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/compile/ColumnNameTrackingExpressionCompiler.java --- @@ -0,0 +1,46 @@ +/* + * Licensed

[GitHub] phoenix pull request #248: Phoenix 3534

2017-05-19 Thread churrodog
Github user churrodog commented on a diff in the pull request: https://github.com/apache/phoenix/pull/248#discussion_r117566388 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableWithViewsIT.java --- @@ -107,12 +107,14 @@ public void

[GitHub] phoenix pull request #236: Loadbalancer

2017-05-19 Thread churrodog
Github user churrodog commented on a diff in the pull request: https://github.com/apache/phoenix/pull/236#discussion_r117542085 --- Diff: phoenix-queryserver/pom.xml --- @@ -147,6 +147,14 @@ commons-logging commons-logging

[GitHub] phoenix issue #248: Phoenix 3534

2017-05-15 Thread churrodog
Github user churrodog commented on the issue: https://github.com/apache/phoenix/pull/248 @twdsilva would you mind taking a look as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] phoenix pull request #248: Phoenix 3534

2017-05-15 Thread churrodog
GitHub user churrodog opened a pull request: https://github.com/apache/phoenix/pull/248 Phoenix 3534 I'll squash these down after a review You can merge this pull request into a Git repository by running: $ git pull https://github.com/churrodog/phoenix PHOENIX

[GitHub] phoenix pull request: PHOENIX-2822 - Tests that extend BaseHBaseMa...

2016-04-08 Thread churrodog
Github user churrodog commented on the pull request: https://github.com/apache/phoenix/pull/158#issuecomment-207610636 @samarthjain rebased and put patch up here: https://issues.apache.org/jira/browse/PHOENIX-2822 . Thanks for the review. --- If your project is set up for it, you

[GitHub] phoenix pull request: PHOENIX-2822 - Tests that extend BaseHBaseMa...

2016-04-08 Thread churrodog
Github user churrodog commented on the pull request: https://github.com/apache/phoenix/pull/158#issuecomment-207521158 made the changes you requested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] phoenix pull request: PHOENIX-2822 - Tests that extend BaseHBaseMa...

2016-04-06 Thread churrodog
Github user churrodog commented on the pull request: https://github.com/apache/phoenix/pull/158#issuecomment-206450571 I also un-ignored the memory manager test in the last commit and fixed it up to remove the long sleeps. --- If your project is set up for it, you can reply to this

[GitHub] phoenix pull request: PHOENIX-2822 - Tests that extend BaseHBaseMa...

2016-04-06 Thread churrodog
Github user churrodog commented on a diff in the pull request: https://github.com/apache/phoenix/pull/158#discussion_r58735016 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/AbsFunctionEnd2EndIT.java --- @@ -43,9 +44,10 @@ public void initTable() throws Exception

[GitHub] phoenix pull request: PHOENIX-2822 - Tests that extend BaseHBaseMa...

2016-04-05 Thread churrodog
GitHub user churrodog opened a pull request: https://github.com/apache/phoenix/pull/158 PHOENIX-2822 - Tests that extend BaseHBaseManagedTimeIT are very slow You can merge this pull request into a Git repository by running: $ git pull https://github.com/churrodog/phoenix